X Tutup
The Wayback Machine - https://web.archive.org/web/20210814055022/https://github.com/nodejs/node/pull/38061
Skip to content

/ node

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fs: move constants to internal/fs/utils.js #38061

Closed
wants to merge 2 commits into from
Closed

fs: move constants to internal/fs/utils.js #38061

wants to merge 2 commits into from

Conversation

@RaisinTen
Copy link
Member

@RaisinTen RaisinTen commented Apr 3, 2021

Refs: #38004 (comment)
@RaisinTen
fs: move constants to internal/fs/utils.js
fcdbf00 
Refs: #38004 (comment)
@mscdex
mscdex reviewed Apr 3, 2021
View changes
lib/internal/fs/utils.js Outdated Show resolved Hide resolved
@aduh95
aduh95 approved these changes Apr 3, 2021
View changes
@Linkgoron
Linkgoron approved these changes Apr 4, 2021
View changes
@RaisinTen
use expression for kMaxUserId
dc60817
@nodejs-github-bot

This comment has been hidden.

Sign in to view
@nodejs-github-bot

This comment has been hidden.

Sign in to view
@jasnell
jasnell approved these changes Apr 6, 2021
View changes
@nodejs-github-bot

This comment has been hidden.

Sign in to view
@nodejs-github-bot

This comment has been hidden.

Sign in to view
@nodejs-github-bot

This comment has been hidden.

Sign in to view
@nodejs-github-bot
Copy link

@nodejs-github-bot nodejs-github-bot commented Apr 6, 2021

CI: https://ci.nodejs.org/job/node-test-pull-request/37210/
@jasnell
Copy link
Member

@jasnell jasnell commented Apr 6, 2021

Landed in 24fd791
@jasnell jasnell closed this Apr 6, 2021
jasnell added a commit that referenced this pull request Apr 6, 2021
@RaisinTen @jasnell
fs: move constants to internal/fs/utils.js
24fd791 
Refs: #38004 (comment)

PR-URL: #38061
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Nitzan Uziely <linkgoron@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@RaisinTen RaisinTen deleted the RaisinTen:fs/move-constants-to-internal/fs/utils.js branch Apr 7, 2021
@BethGriggs BethGriggs mentioned this pull request Apr 12, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mscdex mscdex

@jasnell jasnell

@Linkgoron Linkgoron

@aduh95 aduh95

Assignees
No one assigned
Labels
author ready backport-blocked-v14.x fs needs-ci
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

7 participants
@RaisinTen @nodejs-github-bot @jasnell @mscdex @Linkgoron @aduh95 @targos
X Tutup