X Tutup
The Wayback Machine - https://web.archive.org/web/20210828214407/https://github.com/nodejs/node/pull/38054
Skip to content

/ node

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: fix flaky test-vm-memleak #38054

Merged
merged 1 commit into from Apr 5, 2021
Merged

test: fix flaky test-vm-memleak #38054

merged 1 commit into from Apr 5, 2021
+2 −1

Conversation

@Trott
Copy link
Member

@Trott Trott commented Apr 3, 2021

Force garbage collection so that the memory leak is more easily
differentiated from ordinary not-garbage-collected memory.

Refs: #34289
@Trott
Copy link
Member Author

@Trott Trott commented Apr 3, 2021 •
edited

Pummel CI: https://ci.nodejs.org/job/node-test-commit-custom-suites-freestyle/20015/ ✅

@Trott
Copy link
Member Author

@Trott Trott commented Apr 3, 2021

Pummel tests aren't run (yet) in node-test-pull-request CI jobs, so the pummel CI above should be sufficient here.

@targos
targos approved these changes Apr 3, 2021
View changes
@Trott Trott mentioned this pull request Apr 3, 2021
Merged
1 of 2 tasks
@cjihrig
cjihrig approved these changes Apr 3, 2021
View changes
@Trott
Copy link
Member Author

@Trott Trott commented Apr 3, 2021

(This fixes it on FreeBSD and probably elsewhere, but the test reliably fails on AIX, probably because the baseline RSS is too high. I'll adjust the test further in another PR to address AIX specifically.)

@lpinca
lpinca approved these changes Apr 3, 2021
View changes
@Trott
test: fix flaky test-vm-memleak
4f387c2 
Force garbage collection so that the memory leak is more easily
differentiated from ordinary not-garbage-collected memory.

Refs: #34289

PR-URL: #38054
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@Trott Trott force-pushed the Trott:fix-flaky-memleak branch from 7724d38 to 4f387c2 Apr 5, 2021
@Trott Trott merged commit 4f387c2 into nodejs:master Apr 5, 2021
16 checks passed
16 checks passed
@github-actions
build-tarball
Details
@github-actions
build-windows
Details
@github-actions
coverage-linux
Details
@github-actions
coverage-windows
Details
@github-actions
lint-addon-docs
Details
@github-actions
build-docs
Details
@github-actions
test-asan
Details
@github-actions
test-linux
Details
@github-actions
test-macOS
Details
@github-actions
lint-cpp
Details
@github-actions
lint-md
Details
@github-actions
lint-js
Details
@github-actions
lint-py
Details
@github-actions
lint-sh
Details
@github-actions
lint-codeowners
Details
@github-actions
lint-pr-url
Details
@Trott
Copy link
Member Author

@Trott Trott commented Apr 5, 2021

Landed in 4f387c2

@Trott Trott deleted the Trott:fix-flaky-memleak branch Apr 5, 2021
@BethGriggs BethGriggs mentioned this pull request Apr 12, 2021
Merged
@randomhash randomhash mentioned this pull request Aug 19, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpinca lpinca

@targos targos

@cjihrig cjihrig

Assignees
No one assigned
Labels
backport-blocked-v14.x flaky-test needs-ci test
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@Trott @lpinca @targos @cjihrig @nodejs-github-bot
X Tutup