Formed in 2009, the Archive Team (not to be confused with the archive.org Archive-It Team) is a rogue archivist collective dedicated to saving copies of rapidly dying or deleted websites for the sake of history and digital heritage. The group is 100% composed of volunteers and interested parties, and has expanded into a large amount of related projects for saving online and digital history.
process: runtime deprecate changing process.config #36902
Conversation
The fact that `process.config` is mutable has long made it unreliable when it really should just work. Start the process of deprecating the ability to change it. Fixes: #7803 Signed-off-by: James M Snell <jasnell@gmail.com>
|
Do we have evidence that what people do is replacing the entire object? Intuitively I would say that it's more likely they change individual properties on it. |
|
There were examples that I saw long ago (2015/16) timeframe that changed the whole object but I haven't seen it in a very long time and haven't been able to dig any up recently. I've never seen an application/module that changes individual properties on it. |
|
I found https://github.com/BitGo/key-recovery-service-v2 which replaces the object. How about we also warn if any of the original properties are changed? |
I'd just be worried about the performance cost on start up going through those objects. I guess we could wrap it in a proxy object tho. |
That's what I had in mind |
The fact that
process.configis mutable has long made itunreliable when it really should just work. Start the process
of deprecating the ability to change it.
Fixes: #7803
Signed-off-by: James M Snell jasnell@gmail.com