X Tutup
The Wayback Machine - https://web.archive.org/web/20210814163010/https://github.com/nodejs/node/commit/bd5642deb9
Skip to content
Permalink
Browse files
deps: update V8 postmortem metadata script
This commit updates V8's gen-postmortem-metadata.py script to
fix SmartOS compilation with V8 8.5.

PR-URL: #35415
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
  • Loading branch information
cjihrig authored and targos committed Nov 15, 2020
1 parent 9ae7159 commit bd5642deb9c6fb68309564d4de7142a7671ed8db
Showing with 3 additions and 1 deletion.
  1. +1 −1 common.gypi
  2. +2 −0 deps/v8/tools/gen-postmortem-metadata.py
@@ -36,7 +36,7 @@

# Reset this number to 0 on major V8 upgrades.
# Increment by one for each non-official patch applied to deps/v8.
'v8_embedder_string': '-node.8',
'v8_embedder_string': '-node.9',

##### V8 defaults for Node.js #####

@@ -263,6 +263,8 @@
'UncompiledData, inferred_name, String, kInferredNameOffset',
'UncompiledData, start_position, int32_t, kStartPositionOffset',
'UncompiledData, end_position, int32_t, kEndPositionOffset',
'Script, name, Object, kNameOffset',
'Script, line_ends, Object, kLineEndsOffset',
'SharedFunctionInfo, raw_function_token_offset, int16_t, kFunctionTokenOffsetOffset',
'SharedFunctionInfo, internal_formal_parameter_count, uint16_t, kFormalParameterCountOffset',
'SharedFunctionInfo, flags, int, kFlagsOffset',

0 comments on commit bd5642d

Please sign in to comment.
X Tutup