X Tutup
The Wayback Machine - https://web.archive.org/web/20210701130657/https://github.com/PowerShell/PowerShell/pull/14906
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dev container #14906

Merged
merged 4 commits into from Mar 8, 2021
Merged

Fix dev container #14906

merged 4 commits into from Mar 8, 2021

Conversation

@TylerLeonhardt
Copy link
Member

@TylerLeonhardt TylerLeonhardt commented Feb 26, 2021

PR Summary

The image appeared to be wrong. This fixes it to a working image (although I'm not sure if it's the correct one).

PR Context

Now you can properly use GitHub Codespaces :)

PR Checklist

@msftbot
Copy link

@msftbot msftbot bot commented Mar 5, 2021

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

@rjmholt
Copy link
Member

@rjmholt rjmholt commented Mar 5, 2021

@TravisEz13 @adityapatwardhan or @JamesWTruher I need someone to review this PR to work out if this is the right fix for the PS dev container for codespaces

@msftbot msftbot bot removed the Review - Needed label Mar 5, 2021
.devcontainer/Dockerfile Outdated Show resolved Hide resolved
.devcontainer/Dockerfile Outdated Show resolved Hide resolved
@TravisEz13 TravisEz13 merged commit 6cfdbaa into PowerShell:master Mar 8, 2021
31 checks passed
31 checks passed
@github-actions
Analyze (csharp)
Details
@github-code-scanning
CodeQL No new or fixed alerts
Details
CodeFactor No issues found.
Details
@azure-pipelines
PowerShell-CI-linux Build #PR-14906-20210305.03 succeeded
Details
@azure-pipelines
PowerShell-CI-linux (Build for Linux linux Build) Build for Linux linux Build succeeded
Details
@azure-pipelines
PowerShell-CI-linux (CodeCoverage and Test Packages CodeCoverage and Test Packages) CodeCoverage and Test Packages CodeCoverage and Test Packages succeeded
Details
@azure-pipelines
PowerShell-CI-linux (Test for Linux Linux Test - ElevatedPesterTests - CI) Test for Linux Linux Test - ElevatedPesterTests - CI succeeded
Details
@azure-pipelines
PowerShell-CI-linux (Test for Linux Linux Test - ElevatedPesterTests - Others) Test for Linux Linux Test - ElevatedPesterTests - Others succeeded
Details
@azure-pipelines
PowerShell-CI-linux (Test for Linux Linux Test - UnelevatedPesterTests - CI) Test for Linux Linux Test - UnelevatedPesterTests - CI succeeded
Details
@azure-pipelines
PowerShell-CI-linux (Test for Linux Linux Test - UnelevatedPesterTests - Others) Test for Linux Linux Test - UnelevatedPesterTests - Others succeeded
Details
@azure-pipelines
PowerShell-CI-linux (Test for Linux Verify xUnit Results) Test for Linux Verify xUnit Results succeeded
Details
@azure-pipelines
PowerShell-CI-macos Build #PR-14906-20210305.03 succeeded
Details
@azure-pipelines
PowerShell-CI-macos (Build for macOS macOS Build) Build for macOS macOS Build succeeded
Details
@azure-pipelines
PowerShell-CI-macos (CodeCoverage and Test Packages CodeCoverage and Test Packages) CodeCoverage and Test Packages CodeCoverage and Test Packages succeeded
Details
@azure-pipelines
PowerShell-CI-macos (Test for macOS Verify xUnit Results) Test for macOS Verify xUnit Results succeeded
Details
@azure-pipelines
PowerShell-CI-macos (Test for macOS mac Test - ElevatedPesterTests - CI) Test for macOS mac Test - ElevatedPesterTests - CI succeeded
Details
@azure-pipelines
PowerShell-CI-macos (Test for macOS mac Test - ElevatedPesterTests - Others) Test for macOS mac Test - ElevatedPesterTests - Others succeeded
Details
@azure-pipelines
PowerShell-CI-macos (Test for macOS mac Test - UnelevatedPesterTests - CI) Test for macOS mac Test - UnelevatedPesterTests - CI succeeded
Details
@azure-pipelines
PowerShell-CI-macos (Test for macOS mac Test - UnelevatedPesterTests - Others) Test for macOS mac Test - UnelevatedPesterTests - Others succeeded
Details
@azure-pipelines
PowerShell-CI-static-analysis Build #PR-14906-20210305.03 succeeded
Details
@azure-pipelines
PowerShell-CI-static-analysis (CI Compliance) CI Compliance succeeded
Details
@azure-pipelines
PowerShell-CI-static-analysis (Markdown and Common Tests) Markdown and Common Tests succeeded
Details
@azure-pipelines
PowerShell-CI-windows Build #PR-14906-20210305.03 succeeded
Details
@azure-pipelines
PowerShell-CI-windows (Build for Windows Windows Build) Build for Windows Windows Build succeeded
Details
@azure-pipelines
PowerShell-CI-windows (Test for Windows Verify xUnit Results) Test for Windows Verify xUnit Results succeeded
Details
@azure-pipelines
PowerShell-CI-windows (Test for Windows Windows Test - ElevatedPesterTests - CI) Test for Windows Windows Test - ElevatedPesterTests - CI succeeded
Details
@azure-pipelines
PowerShell-CI-windows (Test for Windows Windows Test - ElevatedPesterTests - Others) Test for Windows Windows Test - ElevatedPesterTests - Others succeeded
Details
@azure-pipelines
PowerShell-CI-windows (Test for Windows Windows Test - UnelevatedPesterTests - CI) Test for Windows Windows Test - UnelevatedPesterTests - CI succeeded
Details
@azure-pipelines
PowerShell-CI-windows (Test for Windows Windows Test - UnelevatedPesterTests - Others) Test for Windows Windows Test - UnelevatedPesterTests - Others succeeded
Details
@wip
WIP Ready for review
Details
@microsoft-cla
license/cla All CLA requirements met.
Details
@TylerLeonhardt TylerLeonhardt deleted the TylerLeonhardt:codespace-504c branch Mar 8, 2021
@TravisEz13 TravisEz13 added this to the 7.2.0-preview.4 milestone Mar 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
X Tutup