X Tutup
The Wayback Machine - https://web.archive.org/web/20210311174511/https://github.com/python/cpython/pull/9933
Skip to content

/ cpython

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3.5] bpo-34623: Use XML_SetHashSalt in _elementtree #9933

Merged
merged 2 commits into from Feb 25, 2019
Merged

[3.5] bpo-34623: Use XML_SetHashSalt in _elementtree #9933

merged 2 commits into from Feb 25, 2019

Conversation

@stratakis
Copy link
Contributor

@stratakis stratakis commented Oct 17, 2018 •
edited by bedevere-bot

https://bugs.python.org/issue34623

https://bugs.python.org/issue34623
miss-islington and others added 2 commits Sep 18, 2018
@miss-islington @tiran @stratakis
bpo-34623: Use XML_SetHashSalt in _elementtree (GH-9146)
73f06a7 
The C accelerated _elementtree module now initializes hash randomization
salt from _Py_HashSecret instead of libexpat's default CPRNG.

Signed-off-by: Christian Heimes <christian@python.org>

https://bugs.python.org/issue34623
(cherry picked from commit cb5778f)

Co-authored-by: Christian Heimes <christian@python.org>
@miss-islington @stratakis
[3.5] bpo-34623: Mention CVE-2018-14647 in news entry (GH-9482) (GH-9489
Loading status checks…
eb0bcb0 
)

https://bugs.python.org/issue34623
(cherry picked from commit 026337a)

Co-authored-by: Christian Heimes <christian@python.org>

https://bugs.python.org/issue34623
@stratakis stratakis changed the title bpo-34623: Use XML_SetHashSalt in _elementtree [3.5]bpo-34623: Use XML_SetHashSalt in _elementtree Oct 17, 2018
@stratakis stratakis changed the title [3.5]bpo-34623: Use XML_SetHashSalt in _elementtree [3.5] bpo-34623: Use XML_SetHashSalt in _elementtree Oct 17, 2018
@vstinner
vstinner approved these changes Oct 18, 2018
View changes
Copy link
Member

@vstinner vstinner left a comment

LGTM.

@tiran: Would you mind to review it as well?
@serhiy-storchaka serhiy-storchaka requested a review from tiran Oct 18, 2018
@vstinner
Copy link
Member

@vstinner vstinner commented Jan 21, 2019

@larryhastings: Hi Larry, would you mind to merge this security fix?
@larryhastings larryhastings merged commit 41b48e7 into python:3.5 Feb 25, 2019
4 checks passed
4 checks passed
bedevere/issue-number Issue number 34623 found
Details
bedevere/maintenance-branch-pr Valid maintenance branch PR title.
bedevere/news News entry found in Misc/NEWS.d
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@bedevere-bot
Copy link

@bedevere-bot bedevere-bot commented Feb 25, 2019

@larryhastings: Please replace # with GH- in the commit message next time. Thanks!
@bedevere-bot bedevere-bot removed the awaiting merge label Feb 25, 2019
@larryhastings
Copy link
Contributor

@larryhastings larryhastings commented Feb 25, 2019

Thanks for the backported fix!
@stratakis stratakis deleted the stratakis:xml branch Jun 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vstinner vstinner

@tiran tiran

Assignees

@larryhastings larryhastings

Labels
CLA signed type-security
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

7 participants
@stratakis @vstinner @bedevere-bot @larryhastings @serhiy-storchaka @the-knights-who-say-ni @miss-islington
X Tutup