Since the gists API payload only accepts JSON, and I don't think it accepts base64-encoded files, I think that it's impossible to use the API to add or modify binary files. We should halt with a descriptive error when someone tries to upload a binary file, and when viewing a gist we should avoid printing binary content to stdout.

It would be a nice addition for the API to accept base64-encoded files, but I believe that's outside the scope of this issue.

In addition, gh gist edit could print a warning about editing binary files or refuse to do it at all.

@mislav I'd like to pick this up since it looks like no one is assigned. Could you assign this to me?

@g14a Go right ahead! Thank you 🙇

@mislav If a gist has multiple files and one of the files is a binary, and the user just tries to gh gist view <id>, do we just block the binary and render the rest of the files or halt the operation altogether? Need some input from you.

@g14a Let's render all non-binary files, and for binary files let's render the file header and a notice like “(Skipping rendering binary content)”

If the user chose to view a specific file, and that file happens to be binary, the command should be aborted with an error such as “Error: file contents is binary”.

got it thanks

Morning! @mislav Here's the PR. #3042 Would like some feedback. Thank you :)