X Tutup
The Wayback Machine - https://web.archive.org/web/20220323060638/https://github.com/nodejs/node/pull/37274
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: performanceEntry.flags style format #37274

Merged
merged 1 commit into from Feb 14, 2021
Merged

Conversation

chengcyber
Copy link
Contributor

@chengcyber chengcyber commented Feb 8, 2021

What

performanceEntry.flags has a different style in doc.

image

miss ` between the performanceEntry.flags

@nodejs-github-bot nodejs-github-bot added doc perf_hooks labels Feb 8, 2021
aduh95
aduh95 approved these changes Feb 8, 2021
Copy link
Contributor

@aduh95 aduh95 left a comment

Good catch! Thanks for the PR 🙏

@aduh95 aduh95 added the author ready label Feb 8, 2021
Lxxyx
Lxxyx approved these changes Feb 8, 2021
lpinca
lpinca approved these changes Feb 8, 2021
PR-URL: nodejs#37274
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@aduh95
Copy link
Contributor

@aduh95 aduh95 commented Feb 14, 2021

Landed in bcb1964

@aduh95 aduh95 merged commit bcb1964 into nodejs:master Feb 14, 2021
16 checks passed
danielleadams added a commit that referenced this issue Feb 16, 2021
PR-URL: #37274
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@danielleadams danielleadams mentioned this pull request Feb 16, 2021
@danielleadams danielleadams mentioned this pull request Feb 16, 2021
targos added a commit that referenced this issue May 1, 2021
PR-URL: #37274
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@danielleadams danielleadams mentioned this pull request May 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready doc perf_hooks
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

8 participants
X Tutup