esm: merge and simplify loader hooks #35524
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested: |
nodejs-github-bot
added
the
esm
|
I’ve been looking into trying to implement loader chaining, where each user loader can modify the return value of the previous one(s), for all hooks. I think we need to merge the |
3 tasks
JakobJingleheimer
added a commit
to JakobJingleheimer/node
that referenced
this issue
Apr 18, 2021
nodejs#35524 did this (not sure whether it's necessary)
|
Completed by #37468 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Demo for reducing the number of hooks and allowing more delegation to the builtin hooks.
Downsides:
getSource. Since we now parse the CommonJS source for named exports, it would likely be fine if we'd return source fromloadanyhow but it's unclear how that would interact with userland hooks.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes