X Tutup
The Wayback Machine - https://web.archive.org/web/20210123211437/https://github.com/nodejs/node/pull/31567
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dns: default to verbatim=true in dns.lookup() #31567

Open
wants to merge 2 commits into
base: master
from

Conversation

@bnoordhuis
Copy link
Member

@bnoordhuis bnoordhuis commented Jan 29, 2020

Switch the default from false (reorder the result so that IPv4 addresses
come before IPv6 addresses) to true (return them exactly as the resolver
sent them to us.)

Fixes: #31566
Refs: #6307
Refs: #20710

Passes make test on my machine but something tells me the CI results won't be so pretty...

Switch the default from false (reorder the result so that IPv4 addresses
come before IPv6 addresses) to true (return them exactly as the resolver
sent them to us.)

Fixes: #31566
Refs: #6307
Refs: #20710
@lpinca
lpinca approved these changes Jan 29, 2020
@Trott
Trott approved these changes Jan 31, 2020
@addaleax
Copy link
Member

@addaleax addaleax commented Jan 31, 2020

Looks like this causes a significant number of failures in CI...

@bnoordhuis
Copy link
Member Author

@bnoordhuis bnoordhuis commented Feb 1, 2020

Yep, I didn't expect anything less. I'll be working on fixing up the tests in the next few days.

@benschulz
Copy link

@benschulz benschulz commented Feb 1, 2020

@bnoordhuis, I'm the original reporter of #6307. I saw the recent activity there and wanted to say that I appreciate all the work that went into this and is still going into it. Thank you.

@jasnell
Copy link
Member

@jasnell jasnell commented Jun 25, 2020

@jasnell jasnell added the stalled label Jun 25, 2020
@bnoordhuis bnoordhuis requested a review from nodejs/net as a code owner Aug 10, 2020
@aduh95 aduh95 added stalled and removed stalled labels Oct 19, 2020
@github-actions
Copy link

@github-actions github-actions bot commented Oct 19, 2020

This issue/PR was marked as stalled, it will be automatically closed in 30 days. If it should remain open, please leave a comment explaining why it should remain open.

@telmich
Copy link

@telmich telmich commented Oct 20, 2020

Ping. What is blocking this to be merged?

@treysis
Copy link

@treysis treysis commented Jan 21, 2021

@telmich Maybe the CI does not support IPv6. but running the code with verbatim=true will make it try to connect to an IPv6 address, which of course fails?

@telmich
Copy link

@telmich telmich commented Jan 21, 2021

@treysis as far as I can see the connect itself is towards an IPv4 address, not an IPv6 address

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

X Tutup