doc: fix alignment of parameters #37422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richardlau
approved these changes
Feb 18, 2021
Trott
approved these changes
Feb 18, 2021
Lxxyx
approved these changes
Feb 18, 2021
marsonya
approved these changes
Feb 18, 2021
Lxxyx
added
the
author ready
RaisinTen
approved these changes
Feb 18, 2021
lpinca
approved these changes
Feb 18, 2021
fix alignment of parameters in napi_fatal_error Signed-off-by: Michael Dawson <mdawson@devrus.com> PR-URL: nodejs#37422 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Zijian Liu <lxxyxzj@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
|
Landed in f37ae3c |
targos
added a commit
that referenced
this issue
Feb 28, 2021
fix alignment of parameters in napi_fatal_error Signed-off-by: Michael Dawson <mdawson@devrus.com> PR-URL: #37422 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Zijian Liu <lxxyxzj@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos
added a commit
that referenced
this issue
May 1, 2021
fix alignment of parameters in napi_fatal_error Signed-off-by: Michael Dawson <mdawson@devrus.com> PR-URL: #37422 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Zijian Liu <lxxyxzj@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
fix alignment of parameters in napi_fatal_error
Signed-off-by: Michael Dawson mdawson@devrus.com