fix(material/stepper): don't allow focus inside a hidden element #21842
Conversation
The CSS `visibility` allows for a child element to become visible, even though its parent is hidden. This becomes a problem for an expanded stepper inside a collapsed sidenav, because it allows the user to tab into the stepper. These changes resolve the issue by transitioning to `visibility: ''` which allows it to be inherited. Fixes angular#21831.
mmalerba
approved these changes
Feb 8, 2021
LGTM
mmalerba
added a commit
that referenced
this issue
Feb 12, 2021
) The CSS `visibility` allows for a child element to become visible, even though its parent is hidden. This becomes a problem for an expanded stepper inside a collapsed sidenav, because it allows the user to tab into the stepper. These changes resolve the issue by transitioning to `visibility: ''` which allows it to be inherited. Fixes #21831. (cherry picked from commit 6f99852)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
The CSS
visibilityallows for a child element to become visible, even though its parent is hidden. This becomes a problem for an expanded stepper inside a collapsed sidenav, because it allows the user to tab into the stepper.These changes resolve the issue by transitioning to
visibility: ''which allows it to be inherited.Fixes #21831.
The text was updated successfully, but these errors were encountered: