Formed in 2009, the Archive Team (not to be confused with the archive.org Archive-It Team) is a rogue archivist collective dedicated to saving copies of rapidly dying or deleted websites for the sake of history and digital heritage. The group is 100% composed of volunteers and interested parties, and has expanded into a large amount of related projects for saving online and digital history.
Make some Python API methods compatible with coming Mixer API changes. #116
+236
−29
Conversation
We are going to change the places-in, population, and observation mixer API methods so that they return maps from dcid to lists of dcids, population dcids, and observation values respectively. Update the corresponding Python API methods so that they work with both the new and old Mixer API versions.
|
Thanks for the change! looks much better now. |
| ]) | ||
| res_json =json.dumps({ | ||
| 'geoId/06085': 'dc/p/crgfn8blpvl35', | ||
| 'geoId/4805000': 'dc/p/f3q9whmjwbf36'}) if kwargs['new_mixer_api'] else json.dumps([ |
| @@ -103,7 +106,7 @@ def read(self): | |||
| and data['measurement_method'] == 'BLSSeasonallyAdjusted': | |||
| if data['dcids'] == ['dc/p/x6t44d8jd95rd', 'dc/p/lr52m1yr46r44', 'dc/p/fs929fynprzs']: | |||
| # Response returned when querying for multiple valid dcids. | |||
| res_json = json.dumps([ | |||
| res_json = json.dumps({'dc/p/x6t44d8jd95rd': '18704962.000000', 'dc/p/lr52m1yr46r44': '3075662.000000', 'dc/p/fs929fynprzs': '1973955.000000'}) if kwargs['new_mixer_api'] else json.dumps([ | |||
| @@ -120,7 +123,7 @@ def read(self): | |||
| return MockResponse(json.dumps({'payload': res_json})) | |||
| if data['dcids'] == ['dc/p/x6t44d8jd95rd', 'dc/MadDcid']: | |||
| # Response returned when querying for a dcid that does not exist. | |||
| res_json = json.dumps([ | |||
| res_json = json.dumps({'dc/p/x6t44d8jd95rd' : '18704962.000000'}) if kwargs['new_mixer_api'] else json.dumps([ | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
We are going to change the places-in, population, and observation mixer API methods
so that they return maps from dcid to lists of dcids, population dcids, and
observation values respectively. Update the corresponding Python API methods so
that they work with both the new and old Mixer API versions.