X Tutup
The Wayback Machine - https://web.archive.org/web/20210125184940/https://github.com/flutter/flutter/pull/71196
Skip to content

/ flutter

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[flutter_tools]fix typo in printHowToConsumeAar,which case sync fail #71196

Merged
merged 1 commit into from Jan 7, 2021
Merged

[flutter_tools]fix typo in printHowToConsumeAar,which case sync fail #71196

merged 1 commit into from Jan 7, 2021

Conversation

@vimerzhao
Copy link
Contributor

@vimerzhao vimerzhao commented Nov 25, 2020

Description

according to: Groovy Language Documentation:

Any Groovy expression can be interpolated in all string literals, apart from single and triple-single-quoted strings.

I change typo ' to ", and modify related tests.
@flutter-dashboard flutter-dashboard bot added the tool label Nov 25, 2020
@google-cla
Copy link

@google-cla google-cla bot commented Nov 25, 2020

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.
@google-cla google-cla bot added the cla: no label Nov 25, 2020
@vimerzhao vimerzhao force-pushed the vimerzhao:fix-gradle-usage-hint-typo branch from ecd9cd6 to ef3873f Nov 25, 2020
@google-cla google-cla bot added cla: yes and removed cla: no labels Nov 25, 2020
@jonahwilliams jonahwilliams requested a review from blasten Dec 3, 2020
@blasten
Copy link
Contributor

@blasten blasten commented Dec 3, 2020

This is fine. Did you intend to fix a typo or change " for '?
@vimerzhao
Copy link
Contributor Author

@vimerzhao vimerzhao commented Dec 4, 2020

This is fine. Did you intend to fix a typo or change " for '?

yes! ' will not work actually.
@zanderso
zanderso reviewed Dec 10, 2020
View changes
AUTHORS Outdated Show resolved Hide resolved
@zanderso
Copy link
Member

@zanderso zanderso commented Dec 17, 2020

[PR Triage] I suspect Linux customer_testing is failing because the PR needs to be rebased. @vimerzhao could you please try rebasing this PR on to of master to retrigger the presubmit checks? Thanks!
@vimerzhao vimerzhao
[flutter_tools]fix typo in printHowToConsumeAar,which case sync fail
Loading status checks…
8c60f11
@vimerzhao vimerzhao force-pushed the vimerzhao:fix-gradle-usage-hint-typo branch from 2b8edf1 to 8c60f11 Dec 18, 2020
@vimerzhao vimerzhao requested a review from zanderso Dec 30, 2020
@jonahwilliams
jonahwilliams approved these changes Jan 7, 2021
View changes
Copy link
Member

@jonahwilliams jonahwilliams left a comment

LGTM
@fluttergithubbot fluttergithubbot merged commit 0e684d0 into flutter:master Jan 7, 2021
53 checks passed
53 checks passed
Google testing Google testing passed!
Details
Linux analyze
Details
Linux build_aar_module_test
Details
Linux build_gallery
Details
Linux build_tests
Details
Linux customer_testing
Details
Linux firebase_abstract_method_smoke_test
Details
Linux firebase_android_embedding_v2_smoke_test
Details
Linux firebase_release_smoke_test
Details
Linux flutter_plugins
Details
Linux fuchsia_precache
Details
Linux gradle_non_android_plugin_test
Details
Linux module_custom_host_app_name_test
Details
Linux module_host_with_custom_build_test
Details
Linux module_test
Details
Linux plugin_test
Details
Linux tool_tests
Details
Linux web_integration_tests
Details
Linux web_long_running_tests
Details
Linux web_tests
Details
Linux web_tool_tests
Details
Mac build_aar_module_test
Details
Mac build_gallery
Details
Mac build_ios_framework_module_test
Details
Mac build_tests
Details
Mac customer_testing
Details
Mac gradle_non_android_plugin_test
Details
Mac module_custom_host_app_name_test
Details
Mac module_host_with_custom_build_test
Details
Mac module_test
Details
Mac module_test_ios
Details
Mac plugin_test
Details
Mac tool_tests
Details
Mac web_tool_tests
Details
WIP Ready for review
Details
Windows build_aar_module_test
Details
Windows build_tests
Details
Windows customer_testing
Details
Windows gradle_non_android_plugin_test
Details
Windows module_custom_host_app_name_test
Details
Windows module_host_with_custom_build_test
Details
Windows module_test
Details
Windows plugin_test
Details
Windows tool_tests
Details
analyze-linux Task Summary
Details
cla/google All necessary CLAs are signed
customer_testing-linux Task Summary
Details
docs-linux Task Summary
Details
flutter-build
Details
flutter-gold All golden file tests have passed.
Details
tool_tests-commands-linux Task Summary
Details
tool_tests-general-linux Task Summary
Details
web_integration_tests Task Summary
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonahwilliams jonahwilliams

@blasten blasten

@zanderso zanderso

Assignees
No one assigned
Labels
cla: yes tool waiting for tree to go green
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@vimerzhao @blasten @zanderso @jonahwilliams @fluttergithubbot
X Tutup