X Tutup
The Wayback Machine - https://web.archive.org/web/20210125025655/https://github.com/microsoft/java-debug/pull/359
Skip to content

/ java-debug

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sort completion by relevance & respect completion filters registered by JLS #359

Merged
merged 2 commits into from Jan 22, 2021
Merged

Sort completion by relevance & respect completion filters registered by JLS #359

merged 2 commits into from Jan 22, 2021

Conversation

@testforstephen
Copy link
Contributor

@testforstephen testforstephen commented Jan 22, 2021

Fixes microsoft/vscode-java-debug#909
@testforstephen
Sort completion by relevance & respect completion filters registered …
Loading status checks…
585108d 
…by JLS
@testforstephen testforstephen force-pushed the testforstephen:jinbo_completion branch from 0c331b1 to 585108d Jan 22, 2021
@testforstephen
Copy link
Contributor Author

@testforstephen testforstephen commented Jan 22, 2021

Old completion list:
image

New completion list:
image
@testforstephen testforstephen requested review from jdneo and Eskibear Jan 22, 2021
@testforstephen
Make checkstyle happy
Loading status checks…
0ce2724
@Eskibear
Eskibear approved these changes Jan 22, 2021
View changes
Copy link
Member

@Eskibear Eskibear left a comment

LGTM.
Later isFiltered and getDeclaringType should be moved to JDT.Core from JDT.UI?
@jdneo
jdneo approved these changes Jan 22, 2021
View changes
@testforstephen
Copy link
Contributor Author

@testforstephen testforstephen commented Jan 22, 2021

Later isFiltered and getDeclaringType should be moved to JDT.Core from JDT.UI?

Agree, ideally this should be placed at jdt.core.manipulation repo.
So far i just follow eclipse.jdt.ls to copy the snippet directly.
@testforstephen testforstephen merged commit ca7d197 into microsoft:master Jan 22, 2021
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla All CLA requirements met.
Details
@testforstephen testforstephen deleted the testforstephen:jinbo_completion branch Jan 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Eskibear Eskibear

@jdneo jdneo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

The sort pf completion list is different from that in editor
3 participants
@testforstephen @Eskibear @jdneo
X Tutup