X Tutup
The Wayback Machine - https://web.archive.org/web/20210121065037/https://github.com/apache/storm/pull/3232
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[STORM-1241] port storm.security.auth.auto-login-module-test to java #3232

Open
wants to merge 3 commits into
base: master
from

Conversation

@nd368
Copy link
Contributor

@nd368 nd368 commented Mar 23, 2020

No description provided.

Copy link
Contributor

@Ethanlm Ethanlm left a comment

Overall looks good.

Can we move this test to storm-client since AutoTGTKrb5LoginModule is actually in storm-client

// Behavior is correct when there is no Subject or TGT
AutoTGTKrb5LoginModule loginModule = new AutoTGTKrb5LoginModule();
Assertions.assertThrows(LoginException.class, loginModule::login);
assertThat(loginModule.commit(), is(false));

This comment has been minimized.

@Ethanlm

Ethanlm Apr 7, 2020
Contributor

use assertFalse here and below?

@nd368
Copy link
Contributor Author

@nd368 nd368 commented Apr 11, 2020

changes made - thanks for review :)

* limitations under the License.
*/

package org.apache.storm.security.auth;

This comment has been minimized.

@Ethanlm

Ethanlm Apr 13, 2020
Contributor

Since this is really testing org.apache.storm.security.auth.kerberos.AutoTGTKrb5LoginModule, can we move the unit test to storm-client/test/jvm/org/apache/storm/security/auth/kerberos/AutoLoginModuleTest.java? Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.
X Tutup