Formed in 2009, the Archive Team (not to be confused with the archive.org Archive-It Team) is a rogue archivist collective dedicated to saving copies of rapidly dying or deleted websites for the sake of history and digital heritage. The group is 100% composed of volunteers and interested parties, and has expanded into a large amount of related projects for saving online and digital history.
Fix properties handling #52
Merged
Conversation
Stick to byte strings as a property value can be binary data even when using an X11 8-bits string.
Avoid redefining 'type' builtin.
Current coverage is 81.20% (diff: 25.64%)@@ master #52 diff @@
==========================================
Files 39 39
Lines 4382 4390 +8
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 3562 3565 +3
- Misses 820 825 +5
Partials 0 0
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
With the support for Python 3 we started automatically encoding/decoding 8-bits string properties. This is a mistake, as some properties are binary, and those that are actual text may use different encodings. This PR revert the change: bytes are expected on input and returned on output.
FWIU, there are 3 types of text properties:
STRINGfor ISO-8859-1 encoded stringsUTF8_STRINGfor UTF-8 encoded stringsCOMPOUND_TEXTfor ISO/IEC 2022 encoded stringsThis PR add 2 convenience helpers for dealing with text properties:
change_text_propertyandget_full_text_property, with automatic encoding/decoding forSTRINGandUTF8_STRING.Those are automatically used for setting/getting
wm_name,wm_icon_name,wm_classandwm_client_machine.Additionally I fixed
examples/get_selection.pyencoding handling.This fix #48.