chore(v2): update Prettier config #2542
Merged
Conversation
lex111
changed the title
|
Oh man. Thanks |
|
According to https://prettier.io/blog/2020/03/21/2.0.0.html, that's the default option right? Why do we still have to manually specify? |
|
Deploy preview for docusaurus-2 ready! Built with commit 862375f |
|
Deploy preview for docusaurus-2 ready! Built with commit fb97c3c |
|
When I upgraded Prettier just now in #2538 I think all the arrow parens were updated. So I think it's the default option now without us having to do anything. |
|
Yes, but my code editor does not know about :) |
|
Ok let's merge this since it's relatively harmless. But I think if your IDE is using your project's Prettier or has an upgraded Prettier, this wouldn't be an issue. |
mohrash92
added a commit
to mohrash92/docusaurus
that referenced
this pull request
Apr 11, 2020
* chore(v2): update prettier config * Update .prettierrc * -- Co-authored-by: Yangshun Tay <tay.yang.shun@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Motivation
Update config Prettier so that it is consistent with the latest version of ESLint config Airbnb , where you now always need to write parentheses😢
https://github.com/airbnb/javascript#arrows--one-arg-parens
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
N/A.
Related PRs
(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)