X Tutup
The Wayback Machine - https://web.archive.org/web/20251229021345/https://github.com/python/cpython/pull/22871
Skip to content

bpo-42112: ZipInfo.from_file removes only needed slashes #22871

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
matan1008 wants to merge 4 commits into
base: main
Choose a base branch
from
Open

bpo-42112: ZipInfo.from_file removes only needed slashes #22871

matan1008 wants to merge 4 commits into from

Conversation

@matan1008
Copy link
Contributor

@matan1008 matan1008 commented Oct 21, 2020 •
edited by bedevere-bot
Loading

@the-knights-who-say-ni
Copy link

the-knights-who-say-ni commented Oct 21, 2020

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

CLA Missing

Our records indicate the following people have not signed the CLA:

@matan1008

For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

If you have recently signed the CLA, please wait at least one business day
before our records are updated.

We also demand... A SHRUBBERY!

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

ZackerySpytz
ZackerySpytz reviewed Nov 1, 2020
View reviewed changes
@github-actions
Copy link

github-actions bot commented Dec 24, 2020

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the stale Stale PR or inactive for long period of time. label Dec 24, 2020
MaxwellDupre
MaxwellDupre suggested changes Feb 5, 2022
View reviewed changes
Copy link
Contributor

@MaxwellDupre MaxwellDupre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks ok; all tests pass. But there is zero documentation, not here, not in the original issue. Could you add some description please, possibly a test case? Also, don't see any test for this change, could add please?

@matan1008
Copy link
Contributor Author

matan1008 commented Feb 5, 2022

I added a test case in 348a679
And explained the issue in 30b5e4d
Since I am pretty new to submitting PRs to python, could you please be more specific?

MaxwellDupre
MaxwellDupre suggested changes Feb 5, 2022
View reviewed changes
Copy link
Contributor

@MaxwellDupre MaxwellDupre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yes I see it now:
test_reading_archive_member_starts_with_slash (test.test_zipfile.OtherTests) ... ok
Your changes are in from_file but the test is in Other.Tests
Is there a reason for that?

Ok, but the info for this change in minimalist in the extreme.

@matan1008 matan1008 mannequin mentioned this pull request Apr 10, 2022
Open
@github-actions github-actions bot removed the stale Stale PR or inactive for long period of time. label Jul 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@ZackerySpytz ZackerySpytz ZackerySpytz left review comments

@MaxwellDupre MaxwellDupre MaxwellDupre requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

awaiting core review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@matan1008 @the-knights-who-say-ni @MaxwellDupre @ZackerySpytz @ezio-melotti @bedevere-bot
X Tutup