X Tutup
The Wayback Machine - https://web.archive.org/web/20220502040742/https://github.com/github/secure_headers/pull/451
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deadlink in readme file in this repo to https://github.com/sourceclear/headlines which does not exist - Status code [404:NotFound] #451

Merged
merged 1 commit into from Dec 23, 2020

Conversation

Copy link
Contributor

@MrCull MrCull commented Dec 23, 2020

In this repo's readme there is a link to: https://github.com/sourceclear/headlines
This is in section for "Similar libraries".
However that is a deadlink and gives Status code [404:NotFound].

Looking at https://github.com/sourceclear there does not appear to be any similar named repos belonging to them.
So I assume this is not a simple typo and that this repo has been removed.

Perhaps the simplest thing to do here is to just remove this "Similar libraries" reference all together?
So that is what I have done in this PR.

However please feel free to suggest an alternate approach.

extra

I recently created a tool that makes use of the GitHub api to find repos that match certain parameters. Then this tool checks the repo's readme files for dead links:
https://github.com/MrCull/GitHub-Repo-ReadMe-Dead-Link-Finder

It can be used to re-check this repo via this url: http://githubreadmechecker.com/Home/Search?SingleRepoUri=https%3a%2f%2fgithub.com%2fgithub%2fsecure_headers

I'd love to hear some feedback on this project so please feel free to to share some thoughts, or even start a discussion on the repo's main GitHub page.

All PRs:

  • [N/A] Has tests
  • Documentation updated

Adding a new header

N/A

Adding a new CSP directive

N/A

…r/headlines which does not exist - Status code [404:NotFound]

In this repo's readme there is a link to: https://github.com/sourceclear/headlines
This is in section for "Similar libraries".
However that is a deadlink and gives Status code [404:NotFound].

Looking at https://github.com/sourceclear there does not appear to be any similar named repos belonging to them.
So I assume this is not a simple typo and that this repo has been removed.

Perhaps the simplest thing to do here is to just remove this "Similar libraries" reference all together?
So that is what I have done in this PR.

However please feel free to suggest an alternate approach.

## extra

I recently created a tool that makes use of the GitHub api to find repos that match certain parameters. Then this tool checks the repo's readme files for dead links: 
http://githubreadmechecker.com/Home/Search?SingleRepoUri=https%3a%2f%2fgithub.com%2fgithub%2fsecure_headers

It can be used to re-check this repo via this url: http://githubreadmechecker.com/Home/Search?SingleRepoUri=https%3a%2f%2fgithub.com%2fgithub%2fsecure_headers

I'd love to hear some feedback on this project so please feel free to to share some thoughts, or even start a discussion on the repo's main GitHub page.
Copy link
Contributor

@oreoshake oreoshake left a comment

Thanks! I can't find a reference to the library that has been updated any time recently.

I'd love to hear some feedback on this project so please feel free to to share some thoughts, or even start a discussion on the repo's main GitHub page.

I didn't look at the implementation but in general, I support this kind of stuff for the projects I run. There are plenty of people in the world who will not respond as well. I'm glad you took the time to explain the change instead a completely generic response (although that could have been automated as well).

@oreoshake oreoshake merged commit 62d5fb8 into github:main Dec 23, 2020
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants
X Tutup