X Tutup
The Wayback Machine - https://web.archive.org/web/20201216071202/https://github.com/chartjs/Chart.js/pull/8113
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/area fill and chart titles #8113

Merged
merged 4 commits into from Nov 30, 2020
Merged

Conversation

@LeeLenaleee
Copy link
Contributor

@LeeLenaleee LeeLenaleee commented Nov 28, 2020

Area fill for stacked line was broken because of #8111
Lot of samples had the title in the wrong place so it didn't show
Added import to Chart so it is available in the utils.js
Skip points for radar chart was not in the list of available samples so didnt show up in the overview

@LeeLenaleee LeeLenaleee changed the title Fix/area fill Fix/area fill and plugin titles Nov 28, 2020
@LeeLenaleee LeeLenaleee changed the title Fix/area fill and plugin titles Fix/area fill and chart titles Nov 29, 2020
@kurkle
kurkle approved these changes Nov 30, 2020
@etimberg etimberg merged commit c3fbe5e into chartjs:master Nov 30, 2020
10 checks passed
10 checks passed
build (ubuntu-latest)
Details
build
Details
build (windows-latest)
Details
finish
Details
Coveralls - ubuntu-latest-chrome Coverage decreased (-0.03%) to 94.898%
Details
Coveralls - ubuntu-latest-firefox Coverage increased (+0.03%) to 94.822%
Details
Coveralls - windows-latest-chrome Coverage decreased (-0.0%) to 94.928%
Details
Coveralls - windows-latest-firefox Coverage decreased (-0.03%) to 94.791%
Details
codeclimate All good!
Details
coverage/coveralls Coverage remained the same at 94.928%
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.
X Tutup