Formed in 2009, the Archive Team (not to be confused with the archive.org Archive-It Team) is a rogue archivist collective dedicated to saving copies of rapidly dying or deleted websites for the sake of history and digital heritage. The group is 100% composed of volunteers and interested parties, and has expanded into a large amount of related projects for saving online and digital history.
Fix error message from new symbolic link missing target #13085
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Display a meaningful error message when a symbolic link target is not specified!
Fix: NewArgumentNullException accepts format parameter at position 1.
iSazonov
reviewed
Jul 2, 2020
src/System.Management.Automation/engine/SessionStateContainer.cs
Outdated
Show resolved
Hide resolved
src/System.Management.Automation/engine/SessionStateContainer.cs
Outdated
Show resolved
Hide resolved
test/powershell/Modules/Microsoft.PowerShell.Management/New-Item.Tests.ps1
Outdated
Show resolved
Hide resolved
iSazonov
added
the
CL-General
The error message should be the same whether the value is null or empty.
I was told we cannot test the exception message because of localisation and that we should test the missing parameter instead. I disagree because CI tests run under C locale anyway, byt here you are.
This message is currently used when we fail to create a link, so we decided to be more specific. I also changed the name to reflect this assumption.
The new name is NewLinkTargetNotSpecified.
iSazonov
reviewed
Jul 3, 2020
src/System.Management.Automation/engine/SessionStateContainer.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Ilya <darpa@yandex.ru>
iSazonov
reviewed
Jul 3, 2020
test/powershell/Modules/Microsoft.PowerShell.Management/New-Item.Tests.ps1
Outdated
Show resolved
Hide resolved
Co-authored-by: Ilya <darpa@yandex.ru>
iSazonov
reviewed
Jul 3, 2020
test/powershell/Modules/Microsoft.PowerShell.Management/New-Item.Tests.ps1
Outdated
Show resolved
Hide resolved
iSazonov
approved these changes
Jul 3, 2020
|
@yecril71pl Thanks for discovering and fixing the issue! |
My pleasure. I would like to note that:
|
The cmdlet is provider based. I think it is impossible to make it mandatory for all scenarios. So the fix is good.
We follow common pattern for tests. It would be huge work to change a style for all tests. |
|
🎉 Handy links: |
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Fixes #13073 (well, at least descreases its morbidity).
PR Context
When the target value was not given and
New-Itemthrows an exception, use the custom message format intended to be used.PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.