Formed in 2009, the Archive Team (not to be confused with the archive.org Archive-It Team) is a rogue archivist collective dedicated to saving copies of rapidly dying or deleted websites for the sake of history and digital heritage. The group is 100% composed of volunteers and interested parties, and has expanded into a large amount of related projects for saving online and digital history.
Qt no keywords #199
Merged
Qt no keywords #199
Conversation
|
Looks great. The one suggestion I have is to add add_definitions(-DQT_NO_KEYWORDS)to the root CMakeLists.txt, so that building the library will fail if a Qt keyword is used. It may be preferable to write: target_compile_definitions(nodes
PRIVATE
QT_NO_KEYWORDS
)Which would accomplish the same thing, but only for the |
|
right, thanks. |
|
Looks like a reasonable improvement. Thank you |
signmotion
added a commit
to signmotion/nodeeditor
that referenced
this pull request
Feb 7, 2019
* Qt no keywords * replace emit with Q_EMIT * add QT_NO_KEYWORDS definition to CMakeLists.txt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
see: #160
using Q_SIGNALS, Q_SLOTS, Q_EMIT instead of qt keywords