Formed in 2009, the Archive Team (not to be confused with the archive.org Archive-It Team) is a rogue archivist collective dedicated to saving copies of rapidly dying or deleted websites for the sake of history and digital heritage. The group is 100% composed of volunteers and interested parties, and has expanded into a large amount of related projects for saving online and digital history.
Dynamic port node #209
Dynamic port node #209
Conversation
|
Hey, this looks awesome. Let me stabilize continuous integration builds and then I come back to your PR. Regards, Dmitry |
|
Could you please rebase onto the latest master and squash your commits? |
Added the example of dynamic node change. Fixed build errors: https://ci.appveyor.com/project/paceholder/nodeeditor/builds/22024775/job/eihd7371k7eo3pn6 Removed an odd "using". Refactoring.
* Qt no keywords * replace emit with Q_EMIT * add QT_NO_KEYWORDS definition to CMakeLists.txt
Added Catch2 to dependencies.
…into dynamic-port-node
|
Did this, Dmitry. |
|
@paceholder , if @signmotion will refuse to fulfill your requirements, please find my pull request with his work squashed and rebased. |
|
Hi, great feature, I've been using it in my fork. I created a new PR with fix #268 for anyone who might need this feature (since the original PR has not been accepted yet) |
|
I played a bit with this branch and the @willys0 fix. The main point is Node::onPortAdded() and Node::onPortRemoved() just resize the underlying connection vector, so they kinda works when the last port is added or removed, but if I have 5 ports connected and remove connection at index 2 the layout breaks. So I guess at least signal portRemoved() e and onPortRemoved should have the index of the connection port removed to correctly remove the right port. |
Thanks for awesome node editor, Dmitry! I played with him a few evenings and delighted with the architect and opportunities for decor it.
I added the signals for add and remove ports. Maybe you want to add this to your repository. Video: https://youtu.be/KUt4qlTLrW0
There is a problem when removing connections. I didn't know how correct remove connections from the FlowScene.