Formed in 2009, the Archive Team (not to be confused with the archive.org Archive-It Team) is a rogue archivist collective dedicated to saving copies of rapidly dying or deleted websites for the sake of history and digital heritage. The group is 100% composed of volunteers and interested parties, and has expanded into a large amount of related projects for saving online and digital history.
Improve registry / creator code #171
Open
Conversation
|
I also made the |
Quincunx271
force-pushed the
Quincunx271:simplify-registry-code
branch
from
ec0b1ba
to
0ad8ba9
added 6 commits
May 30, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Simplifies the registration code, removing duplication, by using tag dispatching, and minimizing the compile-time branch code.
The only difference between the two
registerModelImplfunctions was the way the name was being computed, so rather than usingregisterModelImplto do the compile-time branching, make a newcomputeNamefunction.