X Tutup

COLLECTED BY

Organization: Archive Team

Formed in 2009, the Archive Team (not to be confused with the archive.org Archive-It Team) is a rogue archivist collective dedicated to saving copies of rapidly dying or deleted websites for the sake of history and digital heritage. The group is 100% composed of volunteers and interested parties, and has expanded into a large amount of related projects for saving online and digital history.

History is littered with hundreds of conflicts over the future of a community, group, location or business that were "resolved" when one of the parties stepped ahead and destroyed what was there. With the original point of contention destroyed, the debates would fall to the wayside. Archive Team believes that by duplicated condemned data, the conversation and debate can continue, as well as the richness and insight gained by keeping the materials. Our projects have ranged in size from a single volunteer downloading the data to a small-but-critical site, to over 100 volunteers stepping forward to acquire terabytes of user-created data to save for future generations.

The main site for Archive Team is at archiveteam.org and contains up to the date information on various projects, manifestos, plans and walkthroughs.

This collection contains the output of many Archive Team projects, both ongoing and completed. Thanks to the generous providing of disk space by the Internet Archive, multi-terabyte datasets can be made available, as well as in use by the Wayback Machine, providing a path back to lost websites and work.

Our collection has grown to the point of having sub-collections for the type of data we acquire. If you are seeking to browse the contents of these collections, the Wayback Machine is the best first stop. Otherwise, you are free to dig into the stacks to see what you may find.

The Archive Team Panic Downloads are full pulldowns of currently extant websites, meant to serve as emergency backups for needed sites that are in danger of closing, or which will be missed dearly if suddenly lost due to hard drive crashes or server failures.

Collection: Archive Team: The Github Hitrub

This collection is a set of Github repository archives from two major sets: A panic grab upon the acquisition by Microsoft, and a larger, ongoing set of Pretty Much Everything.

TIMESTAMPS

The Wayback Machine - https://web.archive.org/web/20201220223710/https://github.com/paceholder/nodeeditor/pull/163

paceholder / nodeeditor

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keep registration order as order for context menu #163

Open

Quincunx271 wants to merge 8 commits into paceholder:master from Quincunx271:arbitrary-node-order

Contributor

Quincunx271 commented Apr 30, 2018 •

edited

Implements #147

I kept _categories and _registeredModelsCategory as-is. Someone could've called those functions and stored the variables, and removing them, but especially replacing it with a new data-type, would break their code (replacing could silently break in some cases). My ideal would've been to just change the categories() function to return the std::vector and to change the registeredModelsCategoryAssociation to return a separate map type that preserves insertion order (similar to LinkedHashMap in Java; I would've just combined std::vector and std::unordered_map).

If removing / changing _categories or _registeredModelsCategory is desired, I'll make the change and update this PR.

Note: if we do remove categories(), such that _categories becomes inaccessible through any external functions, it'd be best to change its type from std::set to std::unordered_set

Quincunx271 reviewed

include/nodes/internal/DataModelRegistry.hpp Outdated

  
      @@ -57,11 +60,16 @@ class NODE_EDITOR_PUBLIC DataModelRegistry
    
            QString const name = uniqueModel->name();

            if (_registeredModels.count(name) == 0)

            if (!_registeredModels.count(name))

Quincunx271 Apr 30, 2018 •

edited

Author Contributor

You might find this less readable, but I've seen people treating the count method on std::map or std::set as "contains", which is why I wrote is as !_registeredModels.count(name) here. It might not be desirable, if so, it's easy enough to change this back

Contributor Author

Quincunx271 commented Apr 30, 2018

examples/calculator

This is the registration code (edited to make this comment smaller):

  auto ret = std::make_shared<DataModelRegistry>();

  ret->registerModel<NumberSourceDataModel>("Sources");
  ret->registerModel<NumberDisplayDataModel>("Displays");
  ret->registerModel<AdditionModel>("Operators");
  ret->registerModel<SubtractionModel>("Operators");
  ret->registerModel<MultiplicationModel>("Operators");
  ret->registerModel<DivisionModel>("Operators");
  ret->registerModel<ModuloModel>("Operators");

Before this PR:

After this PR:

The categories can still be sorted after this PR by calling ret->sortCategories()

Quincunx271 force-pushed the Quincunx271:arbitrary-node-order branch from 3edf358 to 15a270d

Quincunx271 added 2 commits


          Keep models of a category in the order of registration

6f623c3


          Keep categories in registration order, but have a way to sort them

a6e4ba4

Quincunx271 force-pushed the Quincunx271:arbitrary-node-order branch from 15a270d to a6e4ba4

Justin Bassett added 6 commits


          Merge branch 'master' into arbitrary-node-order

09a5383


          Extract context menu node creation into a separate widget

f0c9e05


          add test that models within a category are in the order of insertion

7e098e4


          add test that categories are kept in the order of insertion


          Make conforming to earlier versions of Qt (the qAsConst was completel…

aad8153

…y useless in this case


          Export ModelSelectionWidget so that it can be used in the tests on Wi…

ad58b9f

…ndows

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

You can’t perform that action at this time.

X Tutup