X Tutup
The Wayback Machine - https://web.archive.org/web/20201221215014/https://github.com/flutter/flutter/pull/72559
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[flutter_tools] catch fatal build output errors on Linux #72559

Merged
merged 1 commit into from Dec 21, 2020

Conversation

@jpnurmi
Copy link
Contributor

@jpnurmi jpnurmi commented Dec 17, 2020

Description

#71003 added a basic error matcher for Clang errors but missed fatal errors, such as when a header is not found:

/path/to/my_app/linux/my_application.cc:10:10: fatal error: 'non_existent.h' file not found

This PR was split off from #72196.

Related Issues

#33584

Tests

I updated the following tests:

  • test/commands.shard/hermetic/build_linux_test.dart

Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I signed the [CLA].
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

  • No, no existing tests failed, so this is not a breaking change.
  • Yes, this is a breaking change. If not, delete the remainder of this section.
@fluttergithubbot fluttergithubbot merged commit bd08997 into flutter:master Dec 21, 2020
53 checks passed
53 checks passed
Google testing Google testing passed!
Details
Linux analyze
Details
Linux build_aar_module_test
Details
Linux build_gallery
Details
Linux build_tests
Details
Linux customer_testing
Details
Linux firebase_abstract_method_smoke_test
Details
Linux firebase_android_embedding_v2_smoke_test
Details
Linux firebase_release_smoke_test
Details
Linux flutter_plugins
Details
Linux fuchsia_precache
Details
Linux gradle_non_android_plugin_test
Details
Linux module_custom_host_app_name_test
Details
Linux module_host_with_custom_build_test
Details
Linux module_test
Details
Linux plugin_test
Details
Linux tool_tests
Details
Linux web_integration_tests
Details
Linux web_long_running_tests
Details
Linux web_tests
Details
Linux web_tool_tests
Details
Mac build_aar_module_test
Details
Mac build_gallery
Details
Mac build_ios_framework_module_test
Details
Mac build_tests
Details
Mac customer_testing
Details
Mac gradle_non_android_plugin_test
Details
Mac module_custom_host_app_name_test
Details
Mac module_host_with_custom_build_test
Details
Mac module_test
Details
Mac module_test_ios
Details
Mac plugin_test
Details
Mac tool_tests
Details
Mac web_tool_tests
Details
WIP Ready for review
Details
Windows build_aar_module_test
Details
Windows build_tests
Details
Windows customer_testing
Details
Windows gradle_non_android_plugin_test
Details
Windows module_custom_host_app_name_test
Details
Windows module_host_with_custom_build_test
Details
Windows module_test
Details
Windows plugin_test
Details
Windows tool_tests
Details
analyze-linux Task Summary
Details
cla/google All necessary CLAs are signed
customer_testing-linux Task Summary
Details
docs-linux Task Summary
Details
flutter-build
Details
flutter-gold All golden file tests have passed.
Details
tool_tests-commands-linux Task Summary
Details
tool_tests-general-linux Task Summary
Details
web_integration_tests Task Summary
Details
@jpnurmi jpnurmi deleted the jpnurmi:clang-fatal-errors branch Dec 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.
X Tutup