Document @ for the --define option #692

gregorym · 2020-08-08T05:06:22Z

I had to dig through the code in order to figure out how to replace an expression.
I was initially trying to do microbundle --define global=window which should actually be microbundle --define @global=window

@global

I had to dig through the code in order to figure out how to replace an expression. I was initially trying to do `microbundle --define global=window` which should actually be `microbundle --define @global=window`

changeset-bot · 2020-08-08T05:06:23Z

💥 No Changeset

Latest commit: 71ea85b

Merging this PR will not cause any packages to be released. If these changes should not cause updates to packages in this repo, this is fine 🙂

If these changes should be published to npm, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

wardpeet · 2020-08-08T07:26:10Z

@gregorym Thank you for opening this PR. Could we instead add a small section to https://github.com/developit/microbundle#-usage--configuration- that explains how to do definitions with examples?

microbundle/src/lib/option-normalization.js

Lines 5 to 24 in 5881387

    
           export function toReplacementExpression(value, name) { 
        
           	// --define A="1",B='true' produces string: 
        
           	const matches = value.match(/^(['"])(.+)\1$/); 
        
           	if (matches) { 
        
           		return [JSON.stringify(matches[2]), name]; 
        
           	} 
        
           	// --define @assign=Object.assign replaces expressions with expressions: 
        
           	if (name[0] === '@') { 
        
           		return [value, name.substring(1)]; 
        
           	} 
        
           	// --define A=1,B=true produces int/boolean literal: 
        
           	if (/^(true|false|\d+)$/i.test(value)) { 
        
           		return [value, name]; 
        
           	} 
        
           	// default: string literal 
        
           	return [JSON.stringify(value), name]; 
        
           }

Nov	DEC	Jan
	09
2019	2020	2021

developit / microbundle

Document @ for the --define option #692

Document @ for the --define option #692

gregorym commented Aug 8, 2020

changeset-bot bot commented Aug 8, 2020

wardpeet commented Aug 8, 2020

developit / microbundle

Join GitHub today

GitHub is where the world builds software

Document @ for the --define option #692

Document @ for the --define option #692

Conversation

gregorym commented Aug 8, 2020

changeset-bot bot commented Aug 8, 2020

💥 No Changeset

wardpeet commented Aug 8, 2020

Essential cookies

Always active

Analytics cookies