X Tutup
The Wayback Machine - https://web.archive.org/web/20201220180722/https://github.com/flutter/flutter/pull/69668
Skip to content

/ flutter

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix #24469, #67354 #69668

Merged
merged 1 commit into from Nov 25, 2020
Merged

fix #24469, #67354 #69668

merged 1 commit into from Nov 25, 2020
+68 −5

Conversation

@sysint64
Copy link
Contributor

@sysint64 sysint64 commented Nov 3, 2020

Description

The reason why is simple - we transited barrier color from barrierColor to 0x00000000, therefore we smoothly transit from black transparent to the barrierColor, but this is not desirable behavior. For example, if we would like to use a white barrier color, it will be like this 0x00000000 -> 0xFFFFFFFF, but a desirable transition would be 0x00FFFFFF -> 0xFFFFFFFF.

Related Issues

This PR fixes #24469, #67354.
@flutter-dashboard
Copy link

@flutter-dashboard flutter-dashboard bot commented Nov 3, 2020

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.
@google-cla google-cla bot added the cla: yes label Nov 3, 2020
@goderbauer goderbauer requested a review from chunhtai Nov 4, 2020
@chunhtai
chunhtai reviewed Nov 11, 2020
View changes
Copy link
Contributor

@chunhtai chunhtai left a comment

Change looks good, but we need a test.
@goderbauer
Copy link
Member

@goderbauer goderbauer commented Nov 18, 2020

(PR triage): @sysint64 do you have plans to add a test soon as per feedback above?
@sysint64
Copy link
Contributor Author

@sysint64 sysint64 commented Nov 19, 2020 •
edited

(PR triage): @sysint64 do you have plans to add a test soon as per feedback above?

Yes, I'm planning to do this in couple days
@sysint64 sysint64 force-pushed the sysint64:issue-24469 branch from 7c220a1 to 17ae880 Nov 19, 2020
@sysint64 sysint64 requested a review from chunhtai Nov 19, 2020
@sysint64
Copy link
Contributor Author

@sysint64 sysint64 commented Nov 19, 2020

@chunhtai @goderbauer I have added the test.
@sysint64 sysint64 force-pushed the sysint64:issue-24469 branch from 42d6fa1 to aeb34fa Nov 21, 2020
@chunhtai
chunhtai approved these changes Nov 23, 2020
View changes
Copy link
Contributor

@chunhtai chunhtai left a comment

LGTM, one small nit
packages/flutter/test/widgets/routes_test.dart Outdated Show resolved Hide resolved
@sysint64 sysint64 force-pushed the sysint64:issue-24469 branch from e44a145 to 55210bd Nov 24, 2020
@chunhtai
Copy link
Contributor

@chunhtai chunhtai commented Nov 24, 2020

Hi @sysint64 can you rebase off master? this branch seems to be out of date.
@sysint64
Copy link
Contributor Author

@sysint64 sysint64 commented Nov 24, 2020

@chunhtai, I've rebased before I push changes. I checked it, and it's up to date.
@sysint64 sysint64 force-pushed the sysint64:issue-24469 branch from 55210bd to 0ee68d5 Nov 25, 2020
@sysint64
fix #24469 and #67354
Verified
This commit was signed with a verified signature.
sysint64 Andrey Kabylin
GPG key ID: E03BD89AA4AF1E97 Learn about signing commits
Loading status checks…
c57ee44
@sysint64 sysint64 force-pushed the sysint64:issue-24469 branch from 0ee68d5 to c57ee44 Nov 25, 2020
@fluttergithubbot fluttergithubbot merged commit e118e1a into flutter:master Nov 25, 2020
36 checks passed
36 checks passed
Google testing Google testing passed!
Details
Linux analyze
Details
Linux build_gallery
Details
Linux build_tests
Details
Linux customer_testing
Details
Linux docs
Details
Linux firebase_abstract_method_smoke_test
Details
Linux firebase_android_embedding_v2_smoke_test
Details
Linux firebase_release_smoke_test
Details
Linux framework_tests
Details
Linux fuchsia_precache
Details
Linux web_e2e_test
Details
Linux web_integration_tests
Details
Linux web_long_running_tests
Details
Linux web_smoke_test
Details
Linux web_tests
Details
Mac build_gallery
Details
Mac build_tests
Details
Mac customer_testing
Details
Mac framework_tests
Details
WIP Ready for review
Details
Windows build_tests
Details
Windows customer_testing
Details
Windows framework_tests
Details
Windows tool_tests
Details
analyze-linux Task Summary
Details
cla/google All necessary CLAs are signed
customer_testing-linux Task Summary
Details
docs-linux Task Summary
Details
flutter-build
Details
flutter-gold All golden file tests have passed.
Details
framework_tests-libraries-linux Task Summary
Details
framework_tests-misc-linux Task Summary
Details
framework_tests-widgets-linux Task Summary
Details
web_integration_tests Task Summary
Details
web_smoke_test Task Summary
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chunhtai chunhtai

Assignees
No one assigned
Labels
cla: yes framework waiting for tree to go green
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

PageRouteBuilder takes some time to set `barrierColor`.
4 participants
@sysint64 @goderbauer @chunhtai @fluttergithubbot
You can’t perform that action at this time.
X Tutup