watcher: Do not initialize the config in watcher #3403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@theopolis updated the pull request - view changes |
muffins
reviewed
Jun 13, 2017
osquery/core/init.cpp
Outdated
| // Conditionally begin the distributed query service | ||
| auto s = osquery::startDistributed(); | ||
| if (!s.ok()) { | ||
| VLOG(1) << "Not starting the distributed query service: " << s.toString(); |
There was a problem hiding this comment.
I think you need an #include <osquery/logger.h>
theopolis
reviewed
Jun 13, 2017
osquery/main/windows/daemon.cpp
Outdated
| @@ -16,12 +16,9 @@ | |||
|
|
|||
| #include <osquery/core.h> | |||
| #include <osquery/flags.h> | |||
| #include <osquery/logger.h> | |||
There was a problem hiding this comment.
@PoppySeedPlehzr, this is the line that should be included, right?
|
@theopolis updated the pull request - view changes |
|
@theopolis updated the pull request - view changes |
|
@theopolis updated the pull request - view changes |
|
@theopolis updated the pull request - view changes |
trizt
added a commit
to trizt/osquery
that referenced
this issue
May 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
This should fix an error in the watchdog, where an exception is thrown when attempting to use the database. Previously we used the
Config, and on initialization it constructed aSchedule, which attempted to look up the last-failed query from the database.