Add VSTS CI for Windows #7536
Merged
Add VSTS CI for Windows #7536
Conversation
TravisEz13
requested review from
adityapatwardhan,
anmenaga,
dantraMSFT and
daxian-dbw
as
code owners
| @@ -161,7 +161,8 @@ Describe "Get-ChildItem" -Tags "CI" { | |||
| (Get-ChildItem -Path $searchRoot -Directory -Recurse).Count | Should -Be 1 | |||
| } | |||
|
|
|||
| It "Should give .sys file if the fullpath is specified with hidden and force parameter" -Skip:(!$IsWindows) { | |||
| # VSTS machines don't have a page file | |||
iSazonov
Aug 17, 2018
Collaborator
We could find the page file location:
#Open the registry on multiple remote computers
$reg = [Microsoft.Win32.RegistryKey]::OpenRemoteBaseKey('LocalMachine',$server )
$RegKeyPath= "SYSTEM\CurrentControlSet\Control\Session Manager\Memory Management"
$pageFileKey=$reg.OpenSubKey($RegKeyPath)
$pageFileLocation=$pageFileKey.GetValue("ExistingPageFiles")| @@ -79,7 +79,7 @@ Describe "Test-Connection" -tags "CI" { | |||
| } | |||
|
|
|||
| # In VSTS, address is 0.0.0.0 | |||
| It "Force IPv4 with implicit PingOptions" -Skip:(Test-IsVstsLinux) { | |||
| It "Force IPv4 with implicit PingOptions" -Skip:((Test-IsVstsLinux) -or (Test-IsVstsWindows)) { | |||
iSazonov
Aug 16, 2018
Collaborator
I wonder how we'll do remoting tests if VSTS, address is 0.0.0.0?
What about web cmdlet tests? Seems we need add [Feature] to a commit title.
TravisEz13
Aug 16, 2018
•
Author
Member
At this point, only CI has been ported, not Feature tests. We should have a later pull request to enable daily builds and [Feature] etc
| @@ -2,3 +2,5 @@ CHANGELOG.md merge=union | |||
| * text=auto | |||
| *.png binary | |||
| *.rtf binary | |||
| testablescript.ps1 text eol=lf | |||
TravisEz13
Aug 18, 2018
Author
Member
just forcing the line endings to be LF which is what we expect
| condition: succeededOrFailed() | ||
|
|
||
| - powershell: | | ||
| [Net.ServicePointManager]::SecurityProtocol = [Net.ServicePointManager]::SecurityProtocol -bor [Net.SecurityProtocolType]::Tls12 |
build.psm1
Outdated
| $environment += @{'nugetPackagesRoot' = "${env:HOMEDRIVE}${env:HOMEPATH}\.nuget\packages"} | ||
| if(!$env:HOMEPATH) | ||
| { | ||
| $environment += @{'nugetPackagesRoot' = "${env:USERPROFILE}\.nuget\packages"} |
build.psm1
Outdated
| { | ||
| # Remove PSOptions. | ||
| # The file is only used to set the PSOptions. | ||
| Remove-Item -Path $psOptionsPath |
test/powershell/Modules/Microsoft.PowerShell.Security/FileCatalog.Tests.ps1
Outdated
| # We will fail, Write why. | ||
| if($detailResult) | ||
| { | ||
| $detailResult | ConvertTo-Json | Write-Verbose -Verbose |
…ifferent sessions. (#6884)
make sure TestFileCatalog always uses lf endings
TravisEz13
merged commit 40532d9
into
PowerShell:master
7 checks passed
7 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
PR Summary
Access-denied test for Get-Item C:\windows\appcompat\Programs\Install -ErrorAction Stop, because the path does not always existShould give .sys file if the fullpath is specified with hidden and force parameter, because pagefile.sys doesn't always exist and other files don't meet test's requirement.Test-Connectiontests for same reasons they failed on VSTS LinuxTest-FileCatalog should pass when catalog is in the same folder as files being tested, because the CmdLet does not work in that scenarioappveyor.psm1to work with VSTSHelpersRemoting.psm1New-RemoteSessionto work for CimSession (discovered an issue during the investigation)Test wildcard with drive relative directory pathto work when there are multiple drivesNew-CimSessionTests to requireAdmin.gitatttributesso files clone like they do on appveyorPR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:to the beginning of the title and remove the prefix when the PR is ready.[feature]if the change is significant or affects feature tests