X Tutup
The Wayback Machine - https://web.archive.org/web/20201219230823/https://github.com/PowerShell/PowerShell/pull/14461
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support to `$PSStyle` for strikethrough and hyperlinks #14461

Merged
merged 4 commits into from Dec 19, 2020

Conversation

@SteveL-MSFT
Copy link
Member

@SteveL-MSFT SteveL-MSFT commented Dec 18, 2020

PR Summary

Strikethrough was missed in the initial implementation. Hyperlinks are getting more broadly supported so that should be added.

Also added missing tests for FromRGB() method.

PR Context

Fix #14459
Fix #14460

PR Checklist

@SteveL-MSFT SteveL-MSFT requested a review from iSazonov Dec 18, 2020
@iSazonov iSazonov merged commit bc08092 into PowerShell:master Dec 19, 2020
32 checks passed
32 checks passed
Analyze (csharp)
Details
CodeQL No new alerts
Details
CodeFactor No issues found.
Details
PowerShell-CI-linux Build #PR-14461-20201218.04 succeeded
Details
PowerShell-CI-linux (Build for Linux linux Build) Build for Linux linux Build succeeded
Details
PowerShell-CI-linux (CodeCoverage and Test Packages CodeCoverage and Test Packages) CodeCoverage and Test Packages CodeCoverage and Test Packages succeeded
Details
PowerShell-CI-linux (Test for Linux Linux Test - ElevatedPesterTests - CI) Test for Linux Linux Test - ElevatedPesterTests - CI succeeded
Details
PowerShell-CI-linux (Test for Linux Linux Test - ElevatedPesterTests - Others) Test for Linux Linux Test - ElevatedPesterTests - Others succeeded
Details
PowerShell-CI-linux (Test for Linux Linux Test - UnelevatedPesterTests - CI) Test for Linux Linux Test - UnelevatedPesterTests - CI succeeded
Details
PowerShell-CI-linux (Test for Linux Linux Test - UnelevatedPesterTests - Others) Test for Linux Linux Test - UnelevatedPesterTests - Others succeeded
Details
PowerShell-CI-linux (Test for Linux Verify xUnit Results) Test for Linux Verify xUnit Results succeeded
Details
PowerShell-CI-macos Build #PR-14461-20201218.04 succeeded
Details
PowerShell-CI-macos (Build for macOS macOS Build) Build for macOS macOS Build succeeded
Details
PowerShell-CI-macos (CodeCoverage and Test Packages CodeCoverage and Test Packages) CodeCoverage and Test Packages CodeCoverage and Test Packages succeeded
Details
PowerShell-CI-macos (Test for macOS Verify xUnit Results) Test for macOS Verify xUnit Results succeeded
Details
PowerShell-CI-macos (Test for macOS mac Test - ElevatedPesterTests - CI) Test for macOS mac Test - ElevatedPesterTests - CI succeeded
Details
PowerShell-CI-macos (Test for macOS mac Test - ElevatedPesterTests - Others) Test for macOS mac Test - ElevatedPesterTests - Others succeeded
Details
PowerShell-CI-macos (Test for macOS mac Test - UnelevatedPesterTests - CI) Test for macOS mac Test - UnelevatedPesterTests - CI succeeded
Details
PowerShell-CI-macos (Test for macOS mac Test - UnelevatedPesterTests - Others) Test for macOS mac Test - UnelevatedPesterTests - Others succeeded
Details
PowerShell-CI-static-analysis Build #PR-14461-20201218.04 succeeded
Details
PowerShell-CI-static-analysis (Markdown and Common Tests) Markdown and Common Tests succeeded
Details
PowerShell-CI-static-analysis (Secret Scan) Secret Scan succeeded
Details
PowerShell-CI-windows Build #PR-14461-20201218.04 succeeded
Details
PowerShell-CI-windows (Build for Windows Windows Build) Build for Windows Windows Build succeeded
Details
PowerShell-CI-windows (Packaging for Windows Windows Packaging) Packaging for Windows Windows Packaging succeeded
Details
PowerShell-CI-windows (Test for Windows Verify xUnit Results) Test for Windows Verify xUnit Results succeeded
Details
PowerShell-CI-windows (Test for Windows Windows Test - ElevatedPesterTests - CI) Test for Windows Windows Test - ElevatedPesterTests - CI succeeded
Details
PowerShell-CI-windows (Test for Windows Windows Test - ElevatedPesterTests - Others) Test for Windows Windows Test - ElevatedPesterTests - Others succeeded
Details
PowerShell-CI-windows (Test for Windows Windows Test - UnelevatedPesterTests - CI) Test for Windows Windows Test - UnelevatedPesterTests - CI succeeded
Details
PowerShell-CI-windows (Test for Windows Windows Test - UnelevatedPesterTests - Others) Test for Windows Windows Test - UnelevatedPesterTests - Others succeeded
Details
WIP Ready for review
Details
license/cla All CLA requirements met.
Details
@iSazonov iSazonov assigned iSazonov and unassigned daxian-dbw Dec 19, 2020
@iSazonov iSazonov added this to the 7.3-Consider milestone Dec 19, 2020
@SteveL-MSFT SteveL-MSFT deleted the SteveL-MSFT:strikethrough-links branch Dec 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

4 participants
You can’t perform that action at this time.
X Tutup