Formed in 2009, the Archive Team (not to be confused with the archive.org Archive-It Team) is a rogue archivist collective dedicated to saving copies of rapidly dying or deleted websites for the sake of history and digital heritage. The group is 100% composed of volunteers and interested parties, and has expanded into a large amount of related projects for saving online and digital history.
fix(styled-components): Fix react-native-elements related problems #619
Conversation
|
We're back to normal on a lot of things <3
|
| @@ -78,7 +82,7 @@ export const EntityInfo = ({ entity, orgs, locale, navigation }: Props) => { | |||
| }} | |||
| subtitle={entity.company} | |||
| onPress={() => navigateToCompany(entity.company, orgs, navigation)} | |||
| unknown={companyInOrgs(entity.company, orgs)} | |||
| hideChevron={!companyInOrgs(entity.company, orgs)} | |||
This was referenced Nov 4, 2017
|
@machour It is really awesome! |
|
Last commit upgrades RNE to 0.18.2 that fixes another small problem with padding when using hideChevron on an item Before: After: |
|
@gitpoint/maintainers Finally, I determined to merge this important PR. I have to admit that I only tested in iOS simulator by myself. But without it, there are so many bugs in our code base. And personally, I trust @machour have tested thoroughly in both platforms, as well as @andrewda 's review. In the worst case, we can fix later. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Spent the afternoon fixing up the problems introduced by the styled-components migration:
<EntityInfo/>: The test on the company was inverted. Also renamed the prop.<IssueDescription/>: Fix the repo link header, the issue title & use InlineLabel instead of LabelButton for issues/pulls label<IssueEventListItem/>: Fix icon styling<*List />: Adjusted the border bottom color, as the default changed in RNE from 0.7 to 0.17 and this is why we had bolder lines.This should fix #615 #580 and several comments in #569