Formed in 2009, the Archive Team (not to be confused with the archive.org Archive-It Team) is a rogue archivist collective dedicated to saving copies of rapidly dying or deleted websites for the sake of history and digital heritage. The group is 100% composed of volunteers and interested parties, and has expanded into a large amount of related projects for saving online and digital history.
fix: show new issue submit button when keyboard is open #447
Conversation
Move contributors to CONTRIBUTORS.md as the list is getting lon in CONTRIBUTING.md #359
Renaming to official name.
adding dot
show issue submit button when issue comment is large, so it is not hidden under the keyboard
show submit button in new issue screen when keyboard is open 289
| <SectionList> | ||
| <View style={styles.listItemContainer}> | ||
| <KeyboardAvoidingView | ||
| style={{ flex: 1 }} |
| style={{ flex: 1 }} | ||
| behavior={'padding'} | ||
| keyboardVerticalOffset={Platform.select({ | ||
| ios: 65, |
acurat
Oct 7, 2017
Author
Contributor
The keyboardVerticalOffset is different because the height of the following vary by platform.
- React navigation headers.
- Height of the auto suggestion bar.
So I figured both platforms needs separate offset heights.
Moving inline styles to style object
andrewda
changed the title
|
@acurat What if the user is using a custom keyboard that isn't the default system size? GBoard for iOS, for example, is at least another 50px larger than the system default. There's probably a more fluid way to do this. |
|
Here is a screenshot with the GBoard keyboard. It looks fine.
Now, that I re-read the KeyboardAvoidingView's documentation, it makes sense. Need to only offset the react navigation header, the height of which is fixed in this app. _ keyboardVerticalOffset: number This is the distance between the top of the user screen and the react native view, may be non-zero in some use cases. _ Anyways, let me know if there is a better way to do this. |
|
@acurat it does not work for me (Russian keyboard):
|
|
Friendly ping @acurat, just wanted to check in and see if you need any help with this at all :) |
|
@housseindjirdeh Yes, I am not sure I know a better solution for this. Any help is appreciated. |
|
Seems like React Native 0.55 will ship with something interesting for this PR: |
Fixes #289
iOS screenshot
Android screenshot