Formed in 2009, the Archive Team (not to be confused with the archive.org Archive-It Team) is a rogue archivist collective dedicated to saving copies of rapidly dying or deleted websites for the sake of history and digital heritage. The group is 100% composed of volunteers and interested parties, and has expanded into a large amount of related projects for saving online and digital history.
add option for preview navigation behavior #112389
Conversation
|
|
| 'workbench.editor.enablePreviewFromCodeNavigation': { | ||
| 'type': 'boolean', | ||
| 'description': nls.localize('enablePreviewFromCodeNavigation', "Controls whether preview editors should be kept open as regular editors when opening a second editor from the preview (e.g. via go to definition)"), | ||
| 'default': true |
There was a problem hiding this comment.
| 'default': true | |
| 'default': false |
There was a problem hiding this comment.
Are you sure? In my implementation true means new behavior (keeping old preview editor open). Your suggestion would make the old behavior default again. I can also change it to false means new behavior, if that's what you mean.
| @@ -75,7 +77,9 @@ export class CodeEditorService extends CodeEditorServiceImpl { | |||
| // should be pinned or not. This ensures that the source of a navigation | |||
| // is not being replaced by the target. An example is "Goto definition" | |||
| // that otherwise would replace the editor everytime the user navigates. | |||
| const pinPreview = this.configurationService.getValue<boolean>('workbench.editor.enablePreviewFromCodeNavigation'); | |||
There was a problem hiding this comment.
I would prefer if we would lookup this setting similar to how we do it here:
Aka add it to IWorkbenchEditorConfiguration
There was a problem hiding this comment.
changed it, thanks for the pointer
|
@bpasero, would you please help me with the macOS Integration Tests? I'm not sure why it fails all of a sudden, I don't think I changed anything that could cause a timeout... is there a way to restart it? |
|
Thanks |
* add option for preview navigation behavior microsoft#112348 * fix test to comply with changes for microsoft#112348 * fix test to comply with changes for microsoft#112348 * get pinPreview using IWorkbenchEditorConfiguration * adjust for changes Co-authored-by: Benjamin Pasero <benjpas@microsoft.com>
This PR fixes #112348
Let me know whether the description text of the new option is ok, so I can fix it if necessary.