X Tutup
The Wayback Machine - https://web.archive.org/web/20201215133335/https://github.com/python/devguide/pull/587/commits
Skip to content

/ devguide

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix good commit example to use imperative title #587

Merged
merged 5 commits into from May 25, 2020
Merged

Fix good commit example to use imperative title #587

merged 5 commits into from May 25, 2020

Commits on May 21, 2020

  1. Merge remote-tracking branch 'upstream/master'

    @DahlitzFlorian
    DahlitzFlorian committed May 21, 2020
    Verified
    This commit was signed with a verified signature.
    DahlitzFlorian Florian Dahlitz
    GPG key ID: 628E551560123F45 Learn about signing commits
    8b5876f

  2. Fix good commit example to use imperative title 

    - Fix example to use imperative title
- Explicitly mention the preference for imperative over descriptive titles
- Link to the article from Chris Beams
    @DahlitzFlorian
    DahlitzFlorian committed May 21, 2020
    Loading status checks…
    Verified
    This commit was signed with a verified signature.
    DahlitzFlorian Florian Dahlitz
    GPG key ID: 628E551560123F45 Learn about signing commits
    e6432e1

Commits on May 22, 2020

  1. Apply suggestions from code review @aeros

    @DahlitzFlorian
    DahlitzFlorian committed May 22, 2020
    Loading status checks…
    Verified
    This commit was signed with a verified signature.
    DahlitzFlorian Florian Dahlitz
    GPG key ID: 628E551560123F45 Learn about signing commits
    a2a902e

Commits on May 24, 2020

  1. Apply suggestion made by @terryjreedy 

    Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
    @DahlitzFlorian @terryjreedy
    DahlitzFlorian and terryjreedy committed May 24, 2020
    Loading status checks…
    Verified
    This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
    GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
    7d16a28

Commits on May 25, 2020

  1. Apply changes suggested by @aeros 

    Co-authored-by: Kyle Stanley <aeros167@gmail.com>
    @DahlitzFlorian @aeros
    DahlitzFlorian and aeros committed May 25, 2020
    Loading status checks…
    Verified
    This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
    GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
    2be1ce9
You can’t perform that action at this time.
X Tutup