X Tutup
The Wayback Machine - https://web.archive.org/web/20210129114745/https://github.com/apache/iotdb/pull/2166
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

e2e: add a simple E2E case and set up the workflow #2166

Merged
merged 8 commits into from Jan 10, 2021

Conversation

@kezhenxu94
Copy link
Member

@kezhenxu94 kezhenxu94 commented Dec 2, 2020

To enable building an image from the master branch on the fly, this patch rewrites the Dockerfile that was not able to build a docker image, and sets up an workflow yaml file for future E2E tests.

The result can be found here.

P.S. Seems some of the docs links are staled and 404 now

@jixuan1989
Copy link
Member

@jixuan1989 jixuan1989 commented Dec 2, 2020

Nice, thanks!

P.S. Seems some of the docs links are staled and 404 now

Do you mean the website or ..?

@kezhenxu94
Copy link
Member Author

@kezhenxu94 kezhenxu94 commented Dec 3, 2020

Nice, thanks!

P.S. Seems some of the docs links are staled and 404 now

Do you mean the website or ..?

Some urls from the GitHub readme page, like the one under this section https://github.com/apache/iotdb#usage-of-csv-import-and-export-tool "Usage of CSV Import and Export Tool"

@jixuan1989
Copy link
Member

@jixuan1989 jixuan1989 commented Dec 7, 2020

Hi @kezhenxu94, I'd like to merge this PR as I want to use your modified dockerfile. How do you think?

@kezhenxu94
Copy link
Member Author

@kezhenxu94 kezhenxu94 commented Dec 8, 2020

Hi @kezhenxu94, I'd like to merge this PR as I want to use your modified dockerfile. How do you think?

Sure. I'm kind of occupied by other stuffs recently so feel free to merge it for your use and I will continue (if needed) in other pull requests, or help on reviewing

@kezhenxu94 kezhenxu94 force-pushed the kezhenxu94:test/e2e branch from ef9d444 to f5160ab Dec 13, 2020
@kezhenxu94
Copy link
Member Author

@kezhenxu94 kezhenxu94 commented Dec 13, 2020

@jixuan1989 I've just added a simple case so this PR is complete in some degree, though some codes can be optimized if there are better solution in IoTDB, for example:

  • does IoDTB has a similar function like MySQL's /docker-entrypoint-initdb.d/
  • can I execute an entire SQL script from command line with start-cli.sh?
  • seems IoTDB CLI can't fetch all columns (*)? /iotdb/sbin/start-cli.sh -e 'SELECT * FROM root.ln.wf01.wt01' failed while /iotdb/sbin/start-cli.sh -e 'SELECT temperature FROM root.ln.wf01.wt01' succeeded.
@kezhenxu94 kezhenxu94 changed the title test: rewrite Dockerfile to build from sources on the fly e2e: add a simple E2E case and set up the workflow Dec 13, 2020
@kezhenxu94
Copy link
Member Author

@kezhenxu94 kezhenxu94 commented Dec 13, 2020

@sonarcloud
Copy link

@sonarcloud sonarcloud bot commented Dec 13, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@kezhenxu94 kezhenxu94 force-pushed the kezhenxu94:test/e2e branch from de39fd2 to 8e514eb Dec 18, 2020
@jixuan1989 jixuan1989 merged commit 6add2e0 into apache:master Jan 10, 2021
9 of 10 checks passed
9 of 10 checks passed
sonar sonar
Details
E2E (cli)
Details
build (8, ubuntu-latest)
Details
build (8, macos-latest)
Details
build (11.0.x, ubuntu-latest)
Details
build (11.0.x, macos-latest)
Details
build-win (8, windows-latest)
Details
coveralls coveralls
Details
build-win (11.0.x, windows-latest)
Details
Travis CI - Pull Request Build Passed
Details
@kezhenxu94 kezhenxu94 deleted the kezhenxu94:test/e2e branch Jan 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
X Tutup