Formed in 2009, the Archive Team (not to be confused with the archive.org Archive-It Team) is a rogue archivist collective dedicated to saving copies of rapidly dying or deleted websites for the sake of history and digital heritage. The group is 100% composed of volunteers and interested parties, and has expanded into a large amount of related projects for saving online and digital history.
[release-4.1] Undo #39258 (isArray changes) - see overview at #41808 #41849
+23
−441
Conversation
DanielRosenwasser
changed the title
|
Will you reopen #17002 which is now broken again in 4.1.3 (had to re ignore new errors when upgrading) |
This was referenced Feb 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
In our latest design meeting we concluded that it was better to revert the
isArraychanges in #39258 - we'll probably come back to this with #36554.Fixes #41808 by removing the .d.ts change. We think the assignability check is still worth keeping in.