An issue about the TypedArray.prototype.sort(). #6503

NWU-NISL · 2020-09-18T01:25:25Z

A typeerror occurred in ChakraCore when I passed an undefined parameter in TypedArray.prototype.sort(), but other engines, such as V8 and quickjs, did not throw an error. Therefore, I think there may be a problem here.

version

1.11.19

command

ChakraCore/out/Debug/ch testcase.js

testcase

var NISLFuzzingFunc = function(){
    var a = new Uint32Array(1);
    var b = a.sort(undefined);
}
NISLFuzzingFunc();

output

TypeError:[TypedArray].prototype.sort: argument is not a Function object.

expected behavior

No error occurred.

Contributor : @Haobin-Lee

ppenzin · 2020-09-24T06:01:39Z

@chicoxyzzy, @zenparsing, how does this look from spec point of view?

chicoxyzzy · 2020-09-24T10:06:59Z

The compareFn could be undefined in both Array.prototype.sort and %TypedArray%.prototype.sort. The runtime semantics for the latter is defined in https://tc39.es/ecma262/#sec-%typedarray%.prototype.sort

ppenzin · 2020-09-25T04:34:53Z

Thank you @chicoxyzzy!

@NWU-NISL thank you for the report.

ppenzin · 2020-09-25T04:36:42Z

To re-iterate, the behavior should be to do nothing if the sort function is undefined.

chicoxyzzy · 2020-09-25T16:18:46Z

That's not quite correct. If compare function is undefined, then algorithm for comparison is

If x and y are both NaN, return +0.
If x is NaN, return 1.
If y is NaN, return -1.
If x < y, return -1.
If x > y, return 1.
If x is -0 and y is +0, return -1.
If x is +0 and y is -0, return 1.
Return +0.

ppenzin · 2020-09-26T07:03:32Z

Thanks @chicoxyzzy! 👍

ppenzin added good first issue APIs labels Sep 25, 2020

NWU-NISL mentioned this issue Oct 3, 2020

Missing tests for TypedArray.prototype.sort method tc39/test262#2843

Closed

Oct	NOV	Dec
	29
2019	2020	2021

microsoft / ChakraCore

An issue about the TypedArray.prototype.sort(). #6503

An issue about the TypedArray.prototype.sort(). #6503

NWU-NISL commented Sep 18, 2020

ppenzin commented Sep 24, 2020

chicoxyzzy commented Sep 24, 2020

ppenzin commented Sep 25, 2020

ppenzin commented Sep 25, 2020

chicoxyzzy commented Sep 25, 2020 •

edited

ppenzin commented Sep 26, 2020

microsoft / ChakraCore

Join GitHub today

GitHub is where the world builds software

An issue about the TypedArray.prototype.sort(). #6503

An issue about the TypedArray.prototype.sort(). #6503

Comments

NWU-NISL commented Sep 18, 2020

ppenzin commented Sep 24, 2020

chicoxyzzy commented Sep 24, 2020

ppenzin commented Sep 25, 2020

ppenzin commented Sep 25, 2020

chicoxyzzy commented Sep 25, 2020 • edited

ppenzin commented Sep 26, 2020

Essential cookies

Always active

Analytics cookies

chicoxyzzy commented Sep 25, 2020 •

edited