Formed in 2009, the Archive Team (not to be confused with the archive.org Archive-It Team) is a rogue archivist collective dedicated to saving copies of rapidly dying or deleted websites for the sake of history and digital heritage. The group is 100% composed of volunteers and interested parties, and has expanded into a large amount of related projects for saving online and digital history.
Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upIncrease accuracy for gd/imagick alpha channel #1035
Draft
Conversation
increase accuracy on test
increase accuracy on test
Increase accuracy for imagick alpha channel
|
dontEatMe
changed the title
|
Now that fix ready for gd too |
|
...and add missed check for gd tests from imagick tests |
|
: / |
|
TODO add test to binary compare original image and result of 1:1 image convert |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
2 decimal digits accuracy for alpha channel do not cover the entire space of 256(imagick)/128(gd) values (101 values possible only)
fix for that
tests need be changed too (accuracy has been increased)