I ran into a use-case and I'm not sure if this is a bug or feature. Either way maybe some documentation might alleviate the confusion. Was definitely a gotcha that kept me busy for a few hours tracking it down.

For reference: pixijs/pixi.js#5635

I think this might be a regression in behavior, but I'm not 100% positive about that. Maybe I just wasn't paying close enough attention 🤷‍♂

Expected Behavior

When doing a publish or version command when there's a missing name field in the root-level package.json file and where . is not a packages entry in the lerna.json file, then lifecycle hooks (e.g. postversion, prepublishOnly, etc) should get invoked at the root-level.

Current Behavior

Because the default name of the project folder can match the name of a package being published, then Lerna assumes that hasRootedLeaf is true and lifecycle methods are skipped.

Possible Solution

The workaround that I found was to give the root package.json a unique name not shared by any packages.

One solution would be to explicitly require and break on a missing name field in the root-level package.json.

Another idea: I'm not sure that using npm's default behavior in setting basename for the root project.manifest is the best choice here. Maybe it would be more appropriate to assign it a unique name, to avoid the case that the folder name happens to overlap an internal package name. Fewer chances of conflicts and accidentally skipping lifecycle hooks.

Steps to Reproduce (for bugs)

1. Create a standard lerna project (no root leaf package) and name any package the same thing as the root repo project folder's name.
2. Remove any name field from the root-level
3. Also, add a preversion script at the root-level package.json
4. Run lerna version or lerna publish
5. Notice that preversion is never called

Context

Recently published a new major version of PixiJS and lifecycle method that was assumed to be hit, was never. This created a slightly botched published which we hope to correct ASAP.

Your Environment