Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
test: switch to ASSERT_EQ etc. macros #2974
Open
Labels
Comments
|
I'm all for it. |
|
Also +1 |
|
+1 for making it easier to debug test failures. |
|
I haven't had time to work on this. For anyone wanting to pick this up, it should be a fairly mechanical translation - just try to ensure lines stay <= 80 columns. :-) |
|
Picking this up |
Closed
|
Unknowingly, I have mostly done this in #3042; though it seems I still have to do some different macros for unsigned int or pointer tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Wanted to discuss this before opening a PR: is everyone okay with a bulk conversion from the old-style ASSERT macro to the new-style ASSERT_EQ, ASSERT_NE, etc. macros?
It'll cause a bit of churn in
test/but it should make debugging tests a lot easier.