Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upRemoving all stdout stderr from main library. #455
Merged
+33
−123
Conversation
|
The goal here is to make it sane for others to include the library in a project without having to worry about where stdout and stderr go. |
|
I think that @DBJDBJ will appreciate. |
|
Amusingly, this creates a failing performance test. cc @jkeiser |
|
I am ignoring the failing perf. test. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
lemire commentedJan 20, 2020
This remains a few std::cout/std::err and putchar from the main library.
See eddelbuettel/rcppsimdjson#1
cc @eddelbuettel