Formed in 2009, the Archive Team (not to be confused with the archive.org Archive-It Team) is a rogue archivist collective dedicated to saving copies of rapidly dying or deleted websites for the sake of history and digital heritage. The group is 100% composed of volunteers and interested parties, and has expanded into a large amount of related projects for saving online and digital history.
fix(material/expansion): not clearing custom query list #21222
Conversation
`MatAccordion` has a custom `QueryList` for keeping track of its own headers which we weren't destroying. These changes add a call to destroy it since it has the potential of leaking memory.
crisbeto
added
P3
google-cla
bot
added
the
cla: yes
|
@crisbeto @jelbourn This looks LGTM, but doesn't The docs for |
wagnermaciel
dismissed
their
stale review
I'd like to understand why we need to call QueryList.destroy() first, since it should be handled internally.
|
|
crisbeto
added
the
merge ready
`MatAccordion` has a custom `QueryList` for keeping track of its own headers which we weren't destroying. These changes add a call to destroy it since it has the potential of leaking memory. (cherry picked from commit 2076686)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
MatAccordionhas a customQueryListfor keeping track of its own headers which we weren't destroying. These changes add a call to destroy it since it has the potential of leaking memory.