angular / components Public
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(material/datepicker): adjust focused date background for better visibility #21176
Conversation
|
What are the contrast ratios on the text with the new treatment? |
|
5 for dark mode and 11.73 for light mode |
|
What about just using a darker gray? In my mind the color is kind of associated with being selected. I'm also curious what this would look like on a date-range picker, where I think dates in between the 2 selected end points are a similar color to what you used here |
|
This is what it looks like with the range, I think it still looks fine, what do you think? |
|
Ah I scanned the spec but didn't notice that. In that case yeah, lets go with the color |
|
Looking through the designs in the spec (https://material.io/components/date-pickers#desktop-pickers), it seems like the circle is supposed to be transparent with an outline when selecting a range. It may end up complicating the selectors though. A bit further down there's a graphic that says not to use the same colors for selected and hover. |
|
For the part where it says not to use the same style for hover and selected states I think it refers to selected range vs to be selected range. However it does seem like the datepicker and date range picker have slightly different hover state treatments. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |

Formed in 2009, the Archive Team (not to be confused with the archive.org Archive-It Team) is a rogue archivist collective dedicated to saving copies of rapidly dying or deleted websites for the sake of history and digital heritage. The group is 100% composed of volunteers and interested parties, and has expanded into a large amount of related projects for saving online and digital history.






Fixes: #18845
Before:

After:

