X Tutup
The Wayback Machine - https://web.archive.org/web/20201201003936/https://github.com/adobe/react-spectrum/issues/1318
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

types: AriaCheckboxGroupItemProps should make `value` required #1318

Open
stefanprobst opened this issue Nov 30, 2020 · 0 comments
Open

types: AriaCheckboxGroupItemProps should make `value` required #1318

stefanprobst opened this issue Nov 30, 2020 · 0 comments

Comments

@stefanprobst
Copy link
Contributor

@stefanprobst stefanprobst commented Nov 30, 2020

🐛 Bug Report

Currently, the AriaCheckboxGroupItemProps interface extends AriaCheckboxProps and therefore has value?: string. However, i think a checkbox group items actually require setting the value prop, as changing the checkbox group state will not work correctly otherwise(?)

🤔 Expected Behavior

AriaCheckboxGroupItemProps shoud have value: string

😯 Current Behavior

AriaCheckboxGroupItemProps has value?: string

💁 Possible Solution

either explicitly add value: string here or use some RequiredFields helper type

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.
X Tutup