Formed in 2009, the Archive Team (not to be confused with the archive.org Archive-It Team) is a rogue archivist collective dedicated to saving copies of rapidly dying or deleted websites for the sake of history and digital heritage. The group is 100% composed of volunteers and interested parties, and has expanded into a large amount of related projects for saving online and digital history.
Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
pip install wxPython before building the Windows EXE #153
Conversation
cclauss
changed the title
cclauss
changed the title
|
Just some minor feedback: (please don't be offended!)
This describes the "what". That can be seen by the code changes anyway. Try to describe the "why" instead! – It should explain what lead to this PR. Which problem do the changes herein solve. Maybe even refer to evidence, e.g. a failed build or a discussion that triggered making the changes. |
|
Side note: As a reference, the build on AppVeyor creates a working Windows EXE, IIRC. Only the MSI was "empty" (which is discussed in detail in #107 (comment)). |
This pull request pip installs wxPython before pyinstaller creates the Windows EXE file.