X Tutup
The Wayback Machine - https://web.archive.org/web/20201204230156/https://github.com/PythonTurtle/PythonTurtle/pull/146
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub Action: Python 3.9 release candidate 2 #146

Closed
wants to merge 9 commits into from

Conversation

@cclauss
Copy link
Contributor

@cclauss cclauss commented Sep 20, 2020

@cclauss cclauss changed the title WIP: GitHub Action: Python 3.9 release candidate 1 GitHub Action: Python 3.9 release candidate 1 Sep 20, 2020
@bittner
Copy link
Member

@bittner bittner commented Sep 21, 2020

Your current changes don't run any tests. You'd have to extend the Tox configuration (envlist and gh-actions) accordingly.

Can you also describe why you think this is important to add to our setup? Why, e.g., would it not be fine to wait for a final, stable release of v3.9? Think in both the context of a desktop application and its development.

@cclauss
Copy link
Contributor Author

@cclauss cclauss commented Sep 21, 2020

Why test Python 3.9 before it is released?

  1. We could find bugs in Python 3.9... From the release notes:

This release, 3.9.0rc2, is the last preview before the final release of Python 3.9.0 on 2020-10-05. In the mean time, we strongly encourage maintainers of third-party Python projects to prepare their projects for 3.9 compatibility during this phase. As always, report any issues to the Python bug tracker.

  1. Many Python 3.9 breaking changes could effect our code, our build process, or our dependencies.
  2. We could warn our dependencies that they have incompatibilities in code or processes.
  3. In two weeks users will be asking if they can run on the current version of Python and we should prepare an answer.

Also, see wxWidgets/Phoenix#1799 which builds successfully on Python 3.9.0 release candidate 1.

@cool-RR
Copy link
Member

@cool-RR cool-RR commented Sep 21, 2020

Hi @cclauss , thanks for being our newest contributor. I'll let @bittner continue managing this pull request. I'm guessing your contribution is less about PythonTurtle and more about CI, which is fine. In case you were interested in helping the goals of PythonTurtle, the only issue that's important is #107. Right now all the code in this repo is unusable by the children who are the target audience of this project, and that issue aims to fix that.

@bittner
Copy link
Member

@bittner bittner commented Sep 21, 2020

The failing builds fail for wxPython. This looks like it's not building successfully with Python 3.9. It likely doesn't depend on us.

@cclauss
Copy link
Contributor Author

@cclauss cclauss commented Sep 21, 2020

When you say wxPython, do you mean:

If the latter then as I wrote above that builds successfully on Py39rc1.

@cclauss cclauss force-pushed the cclauss:patch-4 branch from 1b85394 to a2b45ac Sep 21, 2020
@bittner
Copy link
Member

@bittner bittner commented Sep 23, 2020

It's whatever is installed with pip install wxPython. The problem is explained at the top of the tox.ini file.

Maybe if you use https://extras.wxpython.org/wxPython4/extras/linux/gtk3/ubuntu-20.04 with the pip install command this will now work?

@cclauss cclauss marked this pull request as draft Sep 23, 2020
cclauss added 3 commits Sep 23, 2020
@cclauss cclauss changed the title GitHub Action: Python 3.9 release candidate 1 GitHub Action: Python 3.9 release candidate 2 Sep 24, 2020
cclauss added 5 commits Sep 24, 2020
@cclauss
Copy link
Contributor Author

@cclauss cclauss commented Sep 24, 2020

Pillow is the problem...

@cclauss cclauss closed this Sep 24, 2020
@cclauss cclauss deleted the cclauss:patch-4 branch Sep 24, 2020
@bittner
Copy link
Member

@bittner bittner commented Sep 24, 2020

I'm really sorry you had to close this PR. I'm grateful you put in the extra mile and tried to make it work.

It's good feedback though that we now are advised to watch out for Pillow to be the problem when jumping on the 3.9 train. Luckily, there are literally thousands of Pillow users out there, so this will soon be noticed and fixed in any case, most likely. Also, we're not strictly dependent on Python 3.9 with the binaries built using PyInstaller, IIUC. That's good.

Thanks again! 🏅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.
X Tutup