X Tutup
The Wayback Machine - https://web.archive.org/web/20201230162707/https://github.com/go-kit/kit/pull/1022
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for JSONRPC opencensus tracing #1022

Merged
merged 1 commit into from Nov 3, 2020

Conversation

@ryan-lang
Copy link
Contributor

@ryan-lang ryan-lang commented Oct 9, 2020

New support for json-rpc opencensus tracing.

To accomplish this without breaking changes, I created a new ServerBeforeCodec JSONRPC server option. Middleware should be able to inspect the details of the rpc request before the codec is invoked, but the existing ServerBefore hook is fired too early -- prior to JSON decode. The new ServerBeforeCodec func is invoked after JSON decode, but prior to codec decode.

@peterbourgon peterbourgon merged commit 1e9fdf6 into go-kit:master Nov 3, 2020
2 checks passed
2 checks passed
Build (1.13) Build (1.13)
Details
Build (1.14) Build (1.14)
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.
X Tutup