Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
Roll Engine from 20caf5496951 to d2ad4419bb07 (27 revisions) #71498
+3
−3
Conversation
…toreDynamicFeatureManager (flutter/engine#22654)
…n more fragments are in the activity (flutter/engine#22692)
…l when there are no locales. (flutter/engine#22608)
|
AutoRoller is stopped; closing the active roll. |
|
Gold has detected about 8 untriaged digest(s) on patchset 27. |
|
Mac build_gallery passing re-run: https://ci.chromium.org/ui/p/flutter/builders/try/Mac%20build_gallery/3175/overview |
|
This pull request is not suitable for automatic merging in its current state.
|
cbracken
merged commit 6a84b02
into
flutter:master
67 of 71 checks passed
67 of 71 checks passed
cla/google
All necessary CLAs are signed
cbracken
added a commit
to cbracken/flutter
that referenced
this pull request
Dec 2, 2020
…ter#71498)" This appears to be triggering an null dereference by calling popSystemNavigator on a null platform plugin delegate. boolean io.flutter.plugin.platform.PlatformPlugin$PlatformPluginDelegate.popSystemNavigator() Relevant logs: ``` 2020-12-01T14:34:34.410242: stderr: [ +6 ms] VMServiceFlutterDriver: >>> {command: get_text, finderType: ByValueKey, keyValueString: status, keyValueType: String} 2020-12-01T14:34:34.490211: stderr: [ +79 ms] VMServiceFlutterDriver: <<< {isError: false, response: {text: ok}, type: _extensionType, method: ext.flutter.driver} 2020-12-01T14:34:34.493011: stderr: [ +2 ms] VMServiceFlutterDriver: >>> {command: tap, finderType: ByValueKey, keyValueString: step, keyValueType: String} 2020-12-01T14:34:34.962001: stdout: [ +468 ms] E/MethodChannel#flutter/platform( 9732): Failed to handle method call 2020-12-01T14:34:34.962222: stdout: [ ] E/MethodChannel#flutter/platform( 9732): java.lang.NullPointerException: Attempt to invoke interface method 'boolean io.flutter.plugin.platform.PlatformPlugin$PlatformPluginDelegate.popSystemNavigator()' on a null object reference 2020-12-01T14:34:34.962356: stdout: [ ] E/MethodChannel#flutter/platform( 9732): at io.flutter.plugin.platform.PlatformPlugin.popSystemNavigator(PlatformPlugin.java:313) 2020-12-01T14:34:34.962499: stdout: [ ] E/MethodChannel#flutter/platform( 9732): at io.flutter.plugin.platform.PlatformPlugin.access$600(PlatformPlugin.java:28) 2020-12-01T14:34:34.962735: stdout: [ ] E/MethodChannel#flutter/platform( 9732): at io.flutter.plugin.platform.PlatformPlugin$1.popSystemNavigator(PlatformPlugin.java:101) 2020-12-01T14:34:34.963047: stdout: [ ] E/MethodChannel#flutter/platform( 9732): at io.flutter.embedding.engine.systemchannels.PlatformChannel$1.onMethodCall(PlatformChannel.java:123) 2020-12-01T14:34:34.963284: stdout: [ ] E/MethodChannel#flutter/platform( 9732): at io.flutter.plugin.common.MethodChannel$IncomingMethodCallHandler.onMessage(MethodChannel.java:233) 2020-12-01T14:34:34.963592: stdout: [ ] E/MethodChannel#flutter/platform( 9732): at io.flutter.embedding.engine.dart.DartMessenger.handleMessageFromDart(DartMessenger.java:85) 2020-12-01T14:34:34.963910: stdout: [ ] E/MethodChannel#flutter/platform( 9732): at io.flutter.embedding.engine.FlutterJNI.handlePlatformMessage(FlutterJNI.java:738) 2020-12-01T14:34:34.964227: stdout: [ ] E/MethodChannel#flutter/platform( 9732): at android.os.MessageQueue.nativePollOnce(Native Method) 2020-12-01T14:34:34.964571: stdout: [ ] E/MethodChannel#flutter/platform( 9732): at android.os.MessageQueue.next(MessageQueue.java:323) 2020-12-01T14:34:34.964805: stdout: [ ] E/MethodChannel#flutter/platform( 9732): at android.os.Looper.loop(Looper.java:136) 2020-12-01T14:34:34.965034: stdout: [ ] E/MethodChannel#flutter/platform( 9732): at android.app.ActivityThread.main(ActivityThread.java:6123) 2020-12-01T14:34:34.965248: stdout: [ ] E/MethodChannel#flutter/platform( 9732): at java.lang.reflect.Method.invoke(Native Method) 2020-12-01T14:34:34.965398: stdout: [ ] E/MethodChannel#flutter/platform( 9732): at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:867) 2020-12-01T14:34:34.965589: stdout: [ ] E/MethodChannel#flutter/platform( 9732): at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:757) 2020-12-01T14:34:34.966863: stderr: [ +1 ms] VMServiceFlutterDriver: <<< {isError: false, response: {}, type: _extensionType, method: ext.flutter.driver} 2020-12-01T14:34:34.967698: stderr: [ ] VMServiceFlutterDriver: >>> {command: get_text, finderType: ByValueKey, keyValueString: status, keyValueType: String} 2020-12-01T14:34:34.986399: stdout: [ +18 ms] E/flutter ( 9732): [ERROR:flutter/shell/common/shell.cc(209)] Dart Unhandled Exception: PlatformException(error, Attempt to invoke interface method 'boolean io.flutter.plugin.platform.PlatformPlugin$PlatformPluginDelegate.popSystemNavigator()' on a null object reference, null, java.lang.NullPointerException: Attempt to invoke interface method 'boolean io.flutter.plugin.platform.PlatformPlugin$PlatformPluginDelegate.popSystemNavigator()' on a null object reference 2020-12-01T14:34:34.986682: stdout: [ ] E/flutter ( 9732): at io.flutter.plugin.platform.PlatformPlugin.popSystemNavigator(PlatformPlugin.java:313) stdout: [ ] E/flutter ( 9732): at io.flutter.plugin.platform.PlatformPlugin.access$600(PlatformPlugin.java:28) 2020-12-01T14:34:34.987013: stdout: [ ] E/flutter ( 9732): at io.flutter.plugin.platform.PlatformPlugin$1.popSystemNavigator(PlatformPlugin.java:101) 2020-12-01T14:34:34.987328: stdout: [ ] E/flutter ( 9732): at io.flutter.embedding.engine.systemchannels.PlatformChannel$1.onMethodCall(PlatformChannel.java:123) 2020-12-01T14:34:34.987547: stdout: [ ] E/flutter ( 9732): at io.flutter.plugin.common.MethodChannel$IncomingMethodCallHandler.onMessage(MethodChannel.java:233) 2020-12-01T14:34:34.987815: stdout: [ ] E/flutter ( 9732): at io.flutter.embedding.engine.dart.DartMessenger.handleMessageFromDart(DartMessenger.java:85) 2020-12-01T14:34:34.988037: stdout: [ ] E/flutter ( 9732): at io.flutter.embedding.engine.FlutterJNI.handlePlatformMessage(FlutterJNI.java:738) 2020-12-01T14:34:34.988246: stdout: [ ] E/flutter ( 9732): at android.os.MessageQueue.nativePollOnce(Native Method) 2020-12-01T14:34:34.988470: stdout: [ ] E/flutter ( 9732): at android.os.MessageQueue.next(MessageQueue.java:323) 2020-12-01T14:34:34.988678: stdout: [ ] E/flutter ( 9732): at android.os.Looper.loop(Looper.java:136) 2020-12-01T14:34:34.988934: stdout: [ ] E/flutter ( 9732): at android.app.ActivityThread.main(ActivityThread.java:6123) 2020-12-01T14:34:34.989112: stdout: [ ] E/flutter ( 9732): at java.lang.reflect.Method.invoke(Native Method) 2020-12-01T14:34:34.989348: stdout: [ ] E/flutter ( 9732): at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:867) 2020-12-01T14:34:34.990016: stdout: [ ] E/flutter ( 9732): at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:757) stdout: [ ] E/flutter ( 9732): ), stack trace: #0 JSONMethodCodec.decodeEnvelope (package:flutter/src/services/message_codecs.dart:159:7) stdout: [ ] E/flutter ( 9732): flutter#1 MethodChannel._invokeMethod (package:flutter/src/services/platform_channel.dart:159:18) 2020-12-01T14:34:34.990374: stdout: [ ] E/flutter ( 9732): <asynchronous suspension> 2020-12-01T14:34:34.990702: stdout: [ ] E/flutter ( 9732): flutter#2 SystemNavigator.pop (package:flutter/src/services/system_navigator.dart:34:5) 2020-12-01T14:34:34.990946: stdout: [ ] E/flutter ( 9732): <asynchronous suspension> ``` This reverts commit 6a84b02.
cbracken
added a commit
that referenced
this pull request
Dec 2, 2020
…)" (#71519) This appears to be triggering an null dereference by calling popSystemNavigator on a null platform plugin delegate. boolean io.flutter.plugin.platform.PlatformPlugin$PlatformPluginDelegate.popSystemNavigator() Relevant logs: ``` 2020-12-01T14:34:34.410242: stderr: [ +6 ms] VMServiceFlutterDriver: >>> {command: get_text, finderType: ByValueKey, keyValueString: status, keyValueType: String} 2020-12-01T14:34:34.490211: stderr: [ +79 ms] VMServiceFlutterDriver: <<< {isError: false, response: {text: ok}, type: _extensionType, method: ext.flutter.driver} 2020-12-01T14:34:34.493011: stderr: [ +2 ms] VMServiceFlutterDriver: >>> {command: tap, finderType: ByValueKey, keyValueString: step, keyValueType: String} 2020-12-01T14:34:34.962001: stdout: [ +468 ms] E/MethodChannel#flutter/platform( 9732): Failed to handle method call 2020-12-01T14:34:34.962222: stdout: [ ] E/MethodChannel#flutter/platform( 9732): java.lang.NullPointerException: Attempt to invoke interface method 'boolean io.flutter.plugin.platform.PlatformPlugin$PlatformPluginDelegate.popSystemNavigator()' on a null object reference 2020-12-01T14:34:34.962356: stdout: [ ] E/MethodChannel#flutter/platform( 9732): at io.flutter.plugin.platform.PlatformPlugin.popSystemNavigator(PlatformPlugin.java:313) 2020-12-01T14:34:34.962499: stdout: [ ] E/MethodChannel#flutter/platform( 9732): at io.flutter.plugin.platform.PlatformPlugin.access$600(PlatformPlugin.java:28) 2020-12-01T14:34:34.962735: stdout: [ ] E/MethodChannel#flutter/platform( 9732): at io.flutter.plugin.platform.PlatformPlugin$1.popSystemNavigator(PlatformPlugin.java:101) 2020-12-01T14:34:34.963047: stdout: [ ] E/MethodChannel#flutter/platform( 9732): at io.flutter.embedding.engine.systemchannels.PlatformChannel$1.onMethodCall(PlatformChannel.java:123) 2020-12-01T14:34:34.963284: stdout: [ ] E/MethodChannel#flutter/platform( 9732): at io.flutter.plugin.common.MethodChannel$IncomingMethodCallHandler.onMessage(MethodChannel.java:233) 2020-12-01T14:34:34.963592: stdout: [ ] E/MethodChannel#flutter/platform( 9732): at io.flutter.embedding.engine.dart.DartMessenger.handleMessageFromDart(DartMessenger.java:85) 2020-12-01T14:34:34.963910: stdout: [ ] E/MethodChannel#flutter/platform( 9732): at io.flutter.embedding.engine.FlutterJNI.handlePlatformMessage(FlutterJNI.java:738) 2020-12-01T14:34:34.964227: stdout: [ ] E/MethodChannel#flutter/platform( 9732): at android.os.MessageQueue.nativePollOnce(Native Method) 2020-12-01T14:34:34.964571: stdout: [ ] E/MethodChannel#flutter/platform( 9732): at android.os.MessageQueue.next(MessageQueue.java:323) 2020-12-01T14:34:34.964805: stdout: [ ] E/MethodChannel#flutter/platform( 9732): at android.os.Looper.loop(Looper.java:136) 2020-12-01T14:34:34.965034: stdout: [ ] E/MethodChannel#flutter/platform( 9732): at android.app.ActivityThread.main(ActivityThread.java:6123) 2020-12-01T14:34:34.965248: stdout: [ ] E/MethodChannel#flutter/platform( 9732): at java.lang.reflect.Method.invoke(Native Method) 2020-12-01T14:34:34.965398: stdout: [ ] E/MethodChannel#flutter/platform( 9732): at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:867) 2020-12-01T14:34:34.965589: stdout: [ ] E/MethodChannel#flutter/platform( 9732): at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:757) 2020-12-01T14:34:34.966863: stderr: [ +1 ms] VMServiceFlutterDriver: <<< {isError: false, response: {}, type: _extensionType, method: ext.flutter.driver} 2020-12-01T14:34:34.967698: stderr: [ ] VMServiceFlutterDriver: >>> {command: get_text, finderType: ByValueKey, keyValueString: status, keyValueType: String} 2020-12-01T14:34:34.986399: stdout: [ +18 ms] E/flutter ( 9732): [ERROR:flutter/shell/common/shell.cc(209)] Dart Unhandled Exception: PlatformException(error, Attempt to invoke interface method 'boolean io.flutter.plugin.platform.PlatformPlugin$PlatformPluginDelegate.popSystemNavigator()' on a null object reference, null, java.lang.NullPointerException: Attempt to invoke interface method 'boolean io.flutter.plugin.platform.PlatformPlugin$PlatformPluginDelegate.popSystemNavigator()' on a null object reference 2020-12-01T14:34:34.986682: stdout: [ ] E/flutter ( 9732): at io.flutter.plugin.platform.PlatformPlugin.popSystemNavigator(PlatformPlugin.java:313) stdout: [ ] E/flutter ( 9732): at io.flutter.plugin.platform.PlatformPlugin.access$600(PlatformPlugin.java:28) 2020-12-01T14:34:34.987013: stdout: [ ] E/flutter ( 9732): at io.flutter.plugin.platform.PlatformPlugin$1.popSystemNavigator(PlatformPlugin.java:101) 2020-12-01T14:34:34.987328: stdout: [ ] E/flutter ( 9732): at io.flutter.embedding.engine.systemchannels.PlatformChannel$1.onMethodCall(PlatformChannel.java:123) 2020-12-01T14:34:34.987547: stdout: [ ] E/flutter ( 9732): at io.flutter.plugin.common.MethodChannel$IncomingMethodCallHandler.onMessage(MethodChannel.java:233) 2020-12-01T14:34:34.987815: stdout: [ ] E/flutter ( 9732): at io.flutter.embedding.engine.dart.DartMessenger.handleMessageFromDart(DartMessenger.java:85) 2020-12-01T14:34:34.988037: stdout: [ ] E/flutter ( 9732): at io.flutter.embedding.engine.FlutterJNI.handlePlatformMessage(FlutterJNI.java:738) 2020-12-01T14:34:34.988246: stdout: [ ] E/flutter ( 9732): at android.os.MessageQueue.nativePollOnce(Native Method) 2020-12-01T14:34:34.988470: stdout: [ ] E/flutter ( 9732): at android.os.MessageQueue.next(MessageQueue.java:323) 2020-12-01T14:34:34.988678: stdout: [ ] E/flutter ( 9732): at android.os.Looper.loop(Looper.java:136) 2020-12-01T14:34:34.988934: stdout: [ ] E/flutter ( 9732): at android.app.ActivityThread.main(ActivityThread.java:6123) 2020-12-01T14:34:34.989112: stdout: [ ] E/flutter ( 9732): at java.lang.reflect.Method.invoke(Native Method) 2020-12-01T14:34:34.989348: stdout: [ ] E/flutter ( 9732): at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:867) 2020-12-01T14:34:34.990016: stdout: [ ] E/flutter ( 9732): at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:757) stdout: [ ] E/flutter ( 9732): ), stack trace: #0 JSONMethodCodec.decodeEnvelope (package:flutter/src/services/message_codecs.dart:159:7) stdout: [ ] E/flutter ( 9732): #1 MethodChannel._invokeMethod (package:flutter/src/services/platform_channel.dart:159:18) 2020-12-01T14:34:34.990374: stdout: [ ] E/flutter ( 9732): <asynchronous suspension> 2020-12-01T14:34:34.990702: stdout: [ ] E/flutter ( 9732): #2 SystemNavigator.pop (package:flutter/src/services/system_navigator.dart:34:5) 2020-12-01T14:34:34.990946: stdout: [ ] E/flutter ( 9732): <asynchronous suspension> ``` This reverts commit 6a84b02.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
flutter/engine@20caf54...d2ad441
2020-12-01 gspencergoog@users.noreply.github.com Fix PlatformDispatcher.locale to return something meaningful when there are no locales. (flutter/engine#22608)
2020-12-01 gspencergoog@users.noreply.github.com Fix race condition in key event handling on Android (flutter/engine#22658)
2020-12-01 dacoharkes@google.com Add file.dart to DEPS (flutter/engine#22794)
2020-12-01 garyq@google.com Add FlutterPlayStoreSplitApplication for simpler opt in to Split AOT (flutter/engine#22752)
2020-12-01 ferhat@gmail.com [web] Optimize Matrix4.identity (flutter/engine#22622)
2020-11-30 skia-flutter-autoroll@skia.org Roll Skia from 70fe17e12f38 to 4c6f57a23e63 (1 revision) (flutter/engine#22781)
2020-11-30 skia-flutter-autoroll@skia.org Roll Dart SDK from 960620d2e811 to 7a2a3968ef53 (12 revisions) (flutter/engine#22778)
2020-11-30 skia-flutter-autoroll@skia.org Roll Skia from fd41d878b13d to 70fe17e12f38 (6 revisions) (flutter/engine#22776)
2020-11-30 mouad.debbar@gmail.com [web] Add new line break type (prohibited) (flutter/engine#22771)
2020-11-30 skia-flutter-autoroll@skia.org Roll Skia from 8d78da910e45 to fd41d878b13d (20 revisions) (flutter/engine#22772)
2020-11-30 74682667+chandarrengoog@users.noreply.github.com Cleanup dart_runner examples & tests. (flutter/engine#22769)
2020-11-30 iska.kaushik@gmail.com Revert "Introduce a delegate class for gpu metal rendering (#22611)" (flutter/engine#22775)
2020-11-30 xster@google.com Let FlutterFragment not pop the whole activity by default when more fragments are in the activity (flutter/engine#22692)
2020-11-30 jakemac@google.com add file package to deps in prep for glob update (flutter/engine#22770)
2020-11-30 jason-simmons@users.noreply.github.com Fix the unchecked conversion warning for searchPaths in PlayStoreDynamicFeatureManager (flutter/engine#22654)
2020-11-30 skia-flutter-autoroll@skia.org Roll Dart SDK from dcd5a8f005a2 to 960620d2e811 (794 revisions) (flutter/engine#22768)
2020-11-30 skia-flutter-autoroll@skia.org Roll Skia from f2efb80bc316 to 8d78da910e45 (5 revisions) (flutter/engine#22754)
2020-11-30 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from 36uDTGJQp... to qpkZl0s5J... (flutter/engine#22753)
2020-11-30 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from un3JixwuO... to Bnaeivv07... (flutter/engine#22757)
2020-11-27 kustermann@google.com Manual roll of Dart SDK from ce76503f5b46 to dcd5a8f005a (flutter/engine#22766)
2020-11-26 dworsham@google.com fuchsia: Ensure full-screen input interceptor (flutter/engine#22687)
2020-11-25 skia-flutter-autoroll@skia.org Roll Skia from 452369182f6e to f2efb80bc316 (4 revisions) (flutter/engine#22750)
2020-11-25 iska.kaushik@gmail.com Introduce a delegate class for gpu metal rendering (flutter/engine#22611)
2020-11-25 skia-flutter-autoroll@skia.org Roll Skia from 51b74afb84d4 to 452369182f6e (1 revision) (flutter/engine#22749)
2020-11-25 hterkelsen@users.noreply.github.com Don't register CanvasKit with
define(flutter/engine#22745)2020-11-25 skia-flutter-autoroll@skia.org Roll Skia from 888c5d3e57eb to 51b74afb84d4 (12 revisions) (flutter/engine#22746)
2020-11-25 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from gkfmiRsIl... to un3JixwuO... (flutter/engine#22744)
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from gkfmiRsIlyNL to Bnaeivv073to
fuchsia/sdk/core/mac-amd64 from 36uDTGJQpFUl to qpkZl0s5J-Nw
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC cbracken@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md